Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: src/compiler.cc

Issue 2185623002: [Interpreter] Fix compiler.cc to consistently check for FLAG_ignition in ShouldUseIgnition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index aada244f7fad8f09c7e8a772a45afaced9858dba..caedf9f8b4ed5ac89a907e436fba8f487daf01fb 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -442,6 +442,8 @@ void EnsureFeedbackMetadata(CompilationInfo* info) {
}
bool ShouldUseIgnition(CompilationInfo* info) {
+ if (!FLAG_ignition) return false;
+
DCHECK(info->has_shared_info());
// When requesting debug code as a replacement for existing code, we provide
@@ -484,7 +486,7 @@ bool GenerateUnoptimizedCode(CompilationInfo* info) {
return true;
}
}
- if (FLAG_ignition && ShouldUseIgnition(info)) {
+ if (ShouldUseIgnition(info)) {
success = interpreter::Interpreter::MakeBytecode(info);
} else {
success = FullCodeGenerator::MakeCode(info);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698