Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2185613002: [heap] Reland "Remove black pages and use black areas instead." (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland "Remove black pages and use black areas instead." BUG=chromium:630969, chromium:630386 LOG=n Committed: https://crrev.com/9e37a07c8de0a20ef2681e26824ff4d329102603 Cr-Commit-Position: refs/heads/master@{#38057}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix comments #

Patch Set 4 : move check to left trimming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -168 lines) Patch
M src/heap/heap.cc View 1 2 3 4 chunks +25 lines, -9 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +9 lines, -4 lines 0 comments Download
M src/heap/incremental-marking.cc View 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +13 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 11 chunks +25 lines, -70 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +26 lines, -8 lines 0 comments Download
M src/heap/marking.h View 2 chunks +92 lines, -19 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 3 chunks +5 lines, -14 lines 0 comments Download
M src/heap/spaces.cc View 7 chunks +58 lines, -22 lines 0 comments Download
M src/heap/spaces-inl.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download
M test/unittests/heap/marking-unittest.cc View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
ulan
lgtm
4 years, 4 months ago (2016-07-26 14:12:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185613002/60001
4 years, 4 months ago (2016-07-26 14:39:20 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-26 14:41:01 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/9e37a07c8de0a20ef2681e26824ff4d329102603 Cr-Commit-Position: refs/heads/master@{#38057}
4 years, 4 months ago (2016-07-26 14:42:56 UTC) #17
Hannes Payer (out of office)
4 years, 4 months ago (2016-07-28 10:03:24 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2183383004/ by hpayer@chromium.org.

The reason for reverting is: Still crashing..

Powered by Google App Engine
This is Rietveld 408576698