Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2185563003: turn bitmaps into images during recording (Closed)

Created:
4 years, 4 months ago by reed1
Modified:
4 years, 4 months ago
Reviewers:
msarett, mtklein, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

turn bitmaps into images during recording BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185563003 Committed: https://skia.googlesource.com/skia/+/9b84f8c8122435b75905a59c67ab1c7ed52d827e

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : update exclusion list for serialize-8888 #

Patch Set 4 : exlucde serialize bleed, remove ImmutableBitmap for records #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -123 lines) Patch
M include/private/SkRecords.h View 1 2 3 3 chunks +0 lines, -50 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +0 lines, -28 lines 0 comments Download
M src/core/SkRecorder.cpp View 3 chunks +7 lines, -26 lines 0 comments Download
M src/core/SkRecords.cpp View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M tools/dm_flags.py View 1 2 3 1 chunk +23 lines, -10 lines 0 comments Download

Messages

Total messages: 28 (16 generated)
reed1
4 years, 4 months ago (2016-07-26 20:56:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185563003/20001
4 years, 4 months ago (2016-07-26 20:58:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/10024)
4 years, 4 months ago (2016-07-26 21:15:25 UTC) #9
mtklein
lgtm, with more to kill https://codereview.chromium.org/2185563003/diff/20001/include/private/SkRecords.h File include/private/SkRecords.h (right): https://codereview.chromium.org/2185563003/diff/20001/include/private/SkRecords.h#newcode155 include/private/SkRecords.h:155: class ImmutableBitmap : SkNoncopyable ...
4 years, 4 months ago (2016-07-26 21:16:15 UTC) #10
f(malita)
lgtm2
4 years, 4 months ago (2016-07-26 21:29:10 UTC) #11
mtklein
On 2016/07/26 21:29:10, f(malita) wrote: > lgtm2 We think this is blocked on https://bugs.chromium.org/p/skia/issues/detail?id=5579
4 years, 4 months ago (2016-07-26 22:45:24 UTC) #12
reed1
I now think it is blocked on skbug.com/5589 instead. I will try to suppress the ...
4 years, 4 months ago (2016-07-28 14:01:18 UTC) #14
reed1
ptal
4 years, 4 months ago (2016-07-28 16:03:41 UTC) #18
mtklein
still lgtm
4 years, 4 months ago (2016-07-28 16:14:22 UTC) #19
reed1
https://codereview.chromium.org/2185563003/diff/20001/include/private/SkRecords.h File include/private/SkRecords.h (right): https://codereview.chromium.org/2185563003/diff/20001/include/private/SkRecords.h#newcode155 include/private/SkRecords.h:155: class ImmutableBitmap : SkNoncopyable { On 2016/07/26 21:16:14, mtklein ...
4 years, 4 months ago (2016-07-28 16:26:46 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185563003/60001
4 years, 4 months ago (2016-07-28 21:25:19 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:26:16 UTC) #28
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9b84f8c8122435b75905a59c67ab1c7ed52d827e

Powered by Google App Engine
This is Rietveld 408576698