Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2185563002: Call sys.exit after logging threads (Closed)

Created:
4 years, 4 months ago by Sergiy Byelozyorov
Modified:
4 years, 4 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M infra/services/builder_alerts/__main__.py View 1 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Sergiy Byelozyorov
This is a follow up for https://codereview.chromium.org/2176403002/.
4 years, 4 months ago (2016-07-26 11:24:10 UTC) #1
tandrii(chromium)
LGTM, thanks for follow up fix % suggestion https://codereview.chromium.org/2185563002/diff/1/infra/services/builder_alerts/__main__.py File infra/services/builder_alerts/__main__.py (right): https://codereview.chromium.org/2185563002/diff/1/infra/services/builder_alerts/__main__.py#newcode457 infra/services/builder_alerts/__main__.py:457: for ...
4 years, 4 months ago (2016-07-26 11:27:23 UTC) #2
Sergiy Byelozyorov
https://codereview.chromium.org/2185563002/diff/1/infra/services/builder_alerts/__main__.py File infra/services/builder_alerts/__main__.py (right): https://codereview.chromium.org/2185563002/diff/1/infra/services/builder_alerts/__main__.py#newcode457 infra/services/builder_alerts/__main__.py:457: for t in threading.enumerate()] On 2016/07/26 11:27:23, tandrii(chromium) wrote: ...
4 years, 4 months ago (2016-07-26 14:15:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185563002/20001
4 years, 4 months ago (2016-07-26 14:15:22 UTC) #6
tandrii(chromium)
https://codereview.chromium.org/2185563002/diff/20001/infra/services/builder_alerts/__main__.py File infra/services/builder_alerts/__main__.py (right): https://codereview.chromium.org/2185563002/diff/20001/infra/services/builder_alerts/__main__.py#newcode458 infra/services/builder_alerts/__main__.py:458: if t is not threading.current_thread()] wow, "is not" actually ...
4 years, 4 months ago (2016-07-26 14:25:57 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 14:28:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/634ed89a1ffc8811efcac46d0078b...

Powered by Google App Engine
This is Rietveld 408576698