infra/services/builder_alerts/__main__.py - Issue 2185563002: Call sys.exit after logging threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/services/builder_alerts/main.py

Issue 2185563002: Call sys.exit after logging threads (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/services/builder_alerts/__main__.py

diff --git a/infra/services/builder_alerts/__main__.py b/infra/services/builder_alerts/__main__.py

index 9107a3f3445b51086982517b626efc4dad275e52..ede241cada5c7b2980816f0318a77335ac935c47 100755

--- a/infra/services/builder_alerts/__main__.py

+++ b/infra/services/builder_alerts/__main__.py

@@ -452,8 +452,10 @@ def main(args):

if __name__ == '__main__':

logging.debug('Started main')

- sys.exit(main(sys.argv[1:]))

+ retcode = main(sys.argv[1:])

current_thread_descriptions = [t.name + (' (daemon)' if t.isDaemon() else '')

- for t in threading.enumerate()]

+ for t in threading.enumerate()

+ if t is not threading.current_thread()]

tandrii(chromium) 2016/07/26 14:25:57 wow, "is not" actually works. I'd use "==".

logging.debug(

'Leaving main. Threads: %s', ', '.join(current_thread_descriptions))

+ sys.exit(retcode)

« no previous file with comments | « no previous file | no next file » | no next file with comments »