Splitting fx_ge_fontmap.cpp

Splitting fx_ge_fontmap.cpp

Move CFX_FolderFontInfo, CFX_FontMgr, and CFX_FontMapper into their own
classes. There are namespaces in each of the new files, having methods
from the original namespace in fx_ge_fontmap, according to what each
class needs.

Committed: https://pdfium.googlesource.com/pdfium/+/f73893a6110f2d4960b372fb4fe38e4fd629ce8f

[npm, 2016-07-26 21:42:45]

Description was changed from

==========
Splitting fx_ge_fontmap
I moved CFX_FolderFontInfo, CFX_FontMgr, and CFX_FontMapper into their own
classes.
There are namespaces in each of the new files, having methods from the original
namespace in fx_ge_fontmap, according to what each class needs.
==========

to

==========
Splitting fx_ge_fontmap
I moved CFX_FolderFontInfo, CFX_FontMgr, and CFX_FontMapper into their own
classes.
There are namespaces in each of the new files, having methods from the original
namespace in fx_ge_fontmap, according to what each class needs.
==========

[npm, 2016-07-26 21:42:45]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-07-26 21:49:05]

Refactoring CL

[Lei Zhang, 2016-07-26 23:15:43]

Description was changed from

==========
Splitting fx_ge_fontmap
I moved CFX_FolderFontInfo, CFX_FontMgr, and CFX_FontMapper into their own
classes.
There are namespaces in each of the new files, having methods from the original
namespace in fx_ge_fontmap, according to what each class needs.
==========

to

==========
Splitting fx_ge_fontmap

Move CFX_FolderFontInfo, CFX_FontMgr, and CFX_FontMapper into their own
classes. There are namespaces in each of the new files, having methods
from the original namespace in fx_ge_fontmap, according to what each
class needs.
==========

[Lei Zhang, 2016-07-26 23:16:11]

Description was changed from

==========
Splitting fx_ge_fontmap

Move CFX_FolderFontInfo, CFX_FontMgr, and CFX_FontMapper into their own
classes. There are namespaces in each of the new files, having methods
from the original namespace in fx_ge_fontmap, according to what each
class needs.
==========

to

==========
Splitting fx_ge_fontmap.cpp

Move CFX_FolderFontInfo, CFX_FontMgr, and CFX_FontMapper into their own
classes. There are namespaces in each of the new files, having methods
from the original namespace in fx_ge_fontmap, according to what each
class needs.
==========

[Lei Zhang, 2016-07-26 23:19:56]

look ok, let's make sure the trybots are happy.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
File core/fxge/ge/cfx_folderfontinfo.cpp (right):

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:7: #include <algorithm>
Include What You Use (IWYU) goes both ways. Include what you need, and exclude
what you don't. In this file, you only need <limits>. Though don't stress out
too much about it.

[Lei Zhang, 2016-07-26 23:20:04]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 23:20:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-07-26 23:21:44]

I also edited the CL description a bit. Try reading a guide on how to write good
git commits.

[commit-bot: I haz the power, 2016-07-26 23:33:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 23:33:02]

Dry run: This issue passed the CQ dry run.

[npm_g, 2016-07-27 14:15:41]

npm@google.com changed reviewers:
+ npm@google.com

[dsinclair, 2016-07-27 14:17:40]

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
File core/fxge/ge/cfx_folderfontinfo.cpp (right):

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:43: if (!FXSYS_fread(buffer.GetBuffer(size),
size, 1, pFile)) {
nit: no {}'s on single line body.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:93: }
nit: ditto

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:104: !!(pitch_family &
FXFONT_FF_FIXEDPITCH)) {
This one can keep the {}'s as the if () is split over multiple lines.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:130: void CFX_FolderFontInfo::ScanPath(const
CFX_ByteString& path) {
nit: blank line before.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:202: void
CFX_FolderFontInfo::ReportFace(const CFX_ByteString& path,
ditto

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:291: return GetFont("Courier New");
nit: {}'s

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:305: }
ditto

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:315: void* CFX_FolderFontInfo::MapFont(int
weight,
nit: blank before

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:382: }
nit: {}'s

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:387: FX_BOOL
CFX_FolderFontInfo::GetFontCharset(void* hFont, int& charset) {
nit: blank before

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cpp
File core/fxge/ge/cfx_fontmgr.cpp (right):

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:75: }
nit: {}'s

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:81: }
nit: {}'s

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:141: FXFT_Face CFX_FontMgr::AddCachedFace(const
CFX_ByteString& face_name,
nit: blank before

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:190: FXFT_Face CFX_FontMgr::AddCachedTTCFace(int
ttc_size,
ditto

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:199: pFontDesc->m_TTCFace.m_pFaces[i] = nullptr;
nit: {}'s

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:231: return;
ditto

https://codereview.chromium.org/2185533006/diff/20001/core/fxge/include/fx_fo...
File core/fxge/include/fx_font.h (right):

https://codereview.chromium.org/2185533006/diff/20001/core/fxge/include/fx_fo...
core/fxge/include/fx_font.h:429: class CFX_FolderFontInfo : public
IFX_SystemFontInfo {
Can you also split the headers out to their own files for each of the classes
you split?

[npm_g, 2016-07-27 17:02:20]

PTAL

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
File core/fxge/ge/cfx_folderfontinfo.cpp (right):

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:7: #include <algorithm>
On 2016/07/26 23:19:56, Lei Zhang (Very Slow) wrote:
> Include What You Use (IWYU) goes both ways. Include what you need, and exclude
> what you don't. In this file, you only need <limits>. Though don't stress out
> too much about it.

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:43: if (!FXSYS_fread(buffer.GetBuffer(size),
size, 1, pFile)) {
On 2016/07/27 14:17:39, dsinclair wrote:
> nit: no {}'s on single line body.

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:93: }
On 2016/07/27 14:17:39, dsinclair wrote:
> nit: ditto

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:104: !!(pitch_family &
FXFONT_FF_FIXEDPITCH)) {
On 2016/07/27 14:17:39, dsinclair wrote:
> This one can keep the {}'s as the if () is split over multiple lines.

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:130: void CFX_FolderFontInfo::ScanPath(const
CFX_ByteString& path) {
On 2016/07/27 14:17:39, dsinclair wrote:
> nit: blank line before.

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:202: void
CFX_FolderFontInfo::ReportFace(const CFX_ByteString& path,
On 2016/07/27 14:17:39, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:291: return GetFont("Courier New");
On 2016/07/27 14:17:39, dsinclair wrote:
> nit: {}'s

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:305: }
On 2016/07/27 14:17:39, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_folderfont...
core/fxge/ge/cfx_folderfontinfo.cpp:315: void* CFX_FolderFontInfo::MapFont(int
weight,
On 2016/07/27 14:17:39, dsinclair wrote:
> nit: blank before

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cpp
File core/fxge/ge/cfx_fontmgr.cpp (right):

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:75: }
On 2016/07/27 14:17:39, dsinclair wrote:
> nit: {}'s

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:81: }
On 2016/07/27 14:17:40, dsinclair wrote:
> nit: {}'s

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:141: FXFT_Face CFX_FontMgr::AddCachedFace(const
CFX_ByteString& face_name,
On 2016/07/27 14:17:39, dsinclair wrote:
> nit: blank before

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:190: FXFT_Face CFX_FontMgr::AddCachedTTCFace(int
ttc_size,
On 2016/07/27 14:17:39, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:199: pFontDesc->m_TTCFace.m_pFaces[i] = nullptr;
On 2016/07/27 14:17:40, dsinclair wrote:
> nit: {}'s

Done.

https://codereview.chromium.org/2185533006/diff/1/core/fxge/ge/cfx_fontmgr.cp...
core/fxge/ge/cfx_fontmgr.cpp:231: return;
On 2016/07/27 14:17:40, dsinclair wrote:
> ditto

Done.

[dsinclair, 2016-07-27 17:36:01]

https://codereview.chromium.org/2185533006/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2185533006/diff/40001/BUILD.gn#newcode695
BUILD.gn:695: "core/fxge/ge/cfx_folderfontinfo.cpp",
Add the header files in here as well.

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
File core/fxge/include/cfx_folderfontinfo.h (right):

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_folderfontinfo.h:1: // Copyright 2014 PDFium Authors. All
rights reserved.
nit: 2016

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_folderfontinfo.h:13: class IFX_SystemFontInfo {
Can you move this to it's own .h file as well? Looks like it's used in a few
places.

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
File core/fxge/include/cfx_fontmapper.h (right):

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontmapper.h:1: // Copyright 2014 PDFium Authors. All
rights reserved.
nit: 2016

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
File core/fxge/include/cfx_fontmgr.h (right):

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontmgr.h:1: // Copyright 2014 PDFium Authors. All rights
reserved.
nit: 2016

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontmgr.h:9: 
This should have a #include <memory> and #include <map>

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/fx_fo...
File core/fxge/include/fx_font.h (right):

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/fx_fo...
core/fxge/include/fx_font.h:72: #define GET_TT_SHORT(w) (uint16_t)(((w)[0] << 8)
| (w)[1])
Do these need to be in the header or can they move into the .cpp file where
they're used?

https://codereview.chromium.org/2185533006/diff/40001/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/2185533006/diff/40001/pdfium.gyp#newcode680
pdfium.gyp:680: "core/fxge/ge/cfx_folderfontinfo.cpp",
Add .h files here as well.

[npm, 2016-07-27 18:51:58]

TALP

https://codereview.chromium.org/2185533006/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2185533006/diff/40001/BUILD.gn#newcode695
BUILD.gn:695: "core/fxge/ge/cfx_folderfontinfo.cpp",
On 2016/07/27 17:36:00, dsinclair wrote:
> Add the header files in here as well.

Done.

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
File core/fxge/include/cfx_folderfontinfo.h (right):

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_folderfontinfo.h:1: // Copyright 2014 PDFium Authors. All
rights reserved.
On 2016/07/27 17:36:01, dsinclair wrote:
> nit: 2016

Done.

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_folderfontinfo.h:13: class IFX_SystemFontInfo {
On 2016/07/27 17:36:01, dsinclair wrote:
> Can you move this to it's own .h file as well? Looks like it's used in a few
> places.

Done.

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
File core/fxge/include/cfx_fontmapper.h (right):

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontmapper.h:1: // Copyright 2014 PDFium Authors. All
rights reserved.
On 2016/07/27 17:36:01, dsinclair wrote:
> nit: 2016

Done.

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
File core/fxge/include/cfx_fontmgr.h (right):

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontmgr.h:1: // Copyright 2014 PDFium Authors. All rights
reserved.
On 2016/07/27 17:36:01, dsinclair wrote:
> nit: 2016

Done.

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/cfx_f...
core/fxge/include/cfx_fontmgr.h:9: 
On 2016/07/27 17:36:01, dsinclair wrote:
> This should have a #include <memory> and #include <map>

Done.

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/fx_fo...
File core/fxge/include/fx_font.h (right):

https://codereview.chromium.org/2185533006/diff/40001/core/fxge/include/fx_fo...
core/fxge/include/fx_font.h:72: #define GET_TT_SHORT(w) (uint16_t)(((w)[0] << 8)
| (w)[1])
On 2016/07/27 17:36:01, dsinclair wrote:
> Do these need to be in the header or can they move into the .cpp file where
> they're used?

Used in a couple of .cpp files

https://codereview.chromium.org/2185533006/diff/40001/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/2185533006/diff/40001/pdfium.gyp#newcode680
pdfium.gyp:680: "core/fxge/ge/cfx_folderfontinfo.cpp",
On 2016/07/27 17:36:01, dsinclair wrote:
> Add .h files here as well.

Done.

[dsinclair, 2016-07-27 19:04:59]

lgtm w/ file move.

https://codereview.chromium.org/2185533006/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2185533006/diff/60001/BUILD.gn#newcode698
BUILD.gn:698: "core/fxge/ge/include/cfx_folderfontinfo.h"
This file is only used in core/ so it doesn't need to be inside the include/
directory.

We put files into include/ if they need to be included from other top level
directories (xfa/, fpdfsdk/, etc). It's, basically, the public API boundary for
this folder.

[npm, 2016-07-27 19:54:03]

The CQ bit was checked by npm@chromium.org

[npm, 2016-07-27 19:54:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2185533006/#ps80001
(title: "Rename cfx_folderfontinfo file")

[commit-bot: I haz the power, 2016-07-27 19:54:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-07-27 19:54:40]

https://codereview.chromium.org/2185533006/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2185533006/diff/60001/BUILD.gn#newcode698
BUILD.gn:698: "core/fxge/ge/include/cfx_folderfontinfo.h"
On 2016/07/27 19:04:58, dsinclair wrote:
> This file is only used in core/ so it doesn't need to be inside the include/
> directory.
> 
> We put files into include/ if they need to be included from other top level
> directories (xfa/, fpdfsdk/, etc). It's, basically, the public API boundary
for
> this folder.

Done.

[commit-bot: I haz the power, 2016-07-27 19:56:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 19:56:38]

Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)

[npm, 2016-07-27 20:00:42]

The CQ bit was checked by npm@chromium.org

[npm, 2016-07-27 20:00:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2185533006/#ps100001
(title: "Missing comma")

[commit-bot: I haz the power, 2016-07-27 20:00:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:05:29]

Try jobs failed on following builders:
  mac_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/...)
  mac_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa_rel_gyp...)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[npm, 2016-07-27 20:27:20]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 20:27:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-07-27 20:30:36]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 20:30:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:52:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:52:58]

Dry run: This issue passed the CQ dry run.

[npm, 2016-07-27 20:54:02]

The CQ bit was checked by npm@chromium.org

[npm, 2016-07-27 20:54:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2185533006/#ps120001
(title: "Add missing includes")

[commit-bot: I haz the power, 2016-07-27 20:54:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:54:31]

Description was changed from

==========
Splitting fx_ge_fontmap.cpp

Move CFX_FolderFontInfo, CFX_FontMgr, and CFX_FontMapper into their own
classes. There are namespaces in each of the new files, having methods
from the original namespace in fx_ge_fontmap, according to what each
class needs.
==========

to

==========
Splitting fx_ge_fontmap.cpp

Move CFX_FolderFontInfo, CFX_FontMgr, and CFX_FontMapper into their own
classes. There are namespaces in each of the new files, having methods
from the original namespace in fx_ge_fontmap, according to what each
class needs.

Committed:
https://pdfium.googlesource.com/pdfium/+/f73893a6110f2d4960b372fb4fe38e4fd629...
==========

[commit-bot: I haz the power, 2016-07-27 20:54:32]

Committed patchset #7 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/f73893a6110f2d4960b372fb4fe38e4fd629...