Simplify color space xform storage and usage (float[] vs. SkMatrix44)

Simplify color space xform storage and usage (float[] vs. SkMatrix44)

Public API is really just internal.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185533005
TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/9f97882322929ee39405acb44cbf155854b38091

[Brian Osman, 2016-07-26 19:12:47]

Description was changed from

==========
Simplify color space xform storage and usage (float[] vs. SkMatrix44)

BUG=skia:
==========

to

==========
Simplify color space xform storage and usage (float[] vs. SkMatrix44)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185533005
==========

[Brian Osman, 2016-07-26 19:13:33]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 19:13:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-07-26 19:13:47]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[robertphillips, 2016-07-26 19:34:38]

Does Vulkan also want column major?

https://codereview.chromium.org/2185533005/diff/1/include/gpu/GrColorSpaceXfo...
File include/gpu/GrColorSpaceXform.h (right):

https://codereview.chromium.org/2185533005/diff/1/include/gpu/GrColorSpaceXfo...
include/gpu/GrColorSpaceXform.h:27: private:
// We store the column major form of the original srcToDst matrix ...

?

[commit-bot: I haz the power, 2016-07-26 19:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 19:44:04]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-07-26 23:14:42]

On 2016/07/26 19:34:38, robertphillips wrote:
> Does Vulkan also want column major?

I have to assume so - there are already other uses of setMatrix4f (and
related APIs) that don't care which API we're using. So really, I think
that column-major is a property of *our* GLSL API, and if any particular
backend wants to deviate from that, it would have to do so inside the
program data manager implementation.

[Brian Osman, 2016-07-26 23:14:58]

Added comment explaining storage.

https://codereview.chromium.org/2185533005/diff/1/include/gpu/GrColorSpaceXfo...
File include/gpu/GrColorSpaceXform.h (right):

https://codereview.chromium.org/2185533005/diff/1/include/gpu/GrColorSpaceXfo...
include/gpu/GrColorSpaceXform.h:27: private:
On 2016/07/26 19:34:38, robertphillips wrote:
> // We store the column major form of the original srcToDst matrix ...
> 
> ?

Done.

[Brian Osman, 2016-07-26 23:15:14]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 23:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:02:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 00:02:04]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-27 00:17:12]

lgtm

[robertphillips, 2016-07-27 00:17:47]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-07-27 00:17:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 00:19:23]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[Brian Osman, 2016-07-27 12:24:20]

Description was changed from

==========
Simplify color space xform storage and usage (float[] vs. SkMatrix44)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185533005
==========

to

==========
Simplify color space xform storage and usage (float[] vs. SkMatrix44)

Public API is really just internal.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185533005
TBR=bsalomon@google.com
==========

[Brian Osman, 2016-07-27 12:24:27]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-07-27 12:24:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 12:25:27]

Description was changed from

==========
Simplify color space xform storage and usage (float[] vs. SkMatrix44)

Public API is really just internal.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185533005
TBR=bsalomon@google.com
==========

to

==========
Simplify color space xform storage and usage (float[] vs. SkMatrix44)

Public API is really just internal.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185533005
TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/9f97882322929ee39405acb44cbf155854b38091
==========

[commit-bot: I haz the power, 2016-07-27 12:25:28]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9f97882322929ee39405acb44cbf155854b38091