Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: include/gpu/GrColorSpaceXform.h

Issue 2185533005: Simplify color space xform storage and usage (float[] vs. SkMatrix44) (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/GrColorSpaceXform.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/GrColorSpaceXform.h
diff --git a/include/gpu/GrColorSpaceXform.h b/include/gpu/GrColorSpaceXform.h
index ea90739fd2f0354f931de32c5b5112db4163aa5a..177230c87c8df72656a38df7f2727980f7dffc27 100644
--- a/include/gpu/GrColorSpaceXform.h
+++ b/include/gpu/GrColorSpaceXform.h
@@ -8,24 +8,25 @@
#ifndef GrColorSpaceXform_DEFINED
#define GrColorSpaceXform_DEFINED
-#include "SkMatrix44.h"
#include "SkRefCnt.h"
class SkColorSpace;
+class SkMatrix44;
/**
* Represents a color gamut transformation (as a 4x4 color matrix)
*/
class GrColorSpaceXform : public SkRefCnt {
public:
- GrColorSpaceXform(const SkMatrix44& srcToDst) : fSrcToDst(srcToDst) {}
+ GrColorSpaceXform(const SkMatrix44& srcToDst);
static sk_sp<GrColorSpaceXform> Make(SkColorSpace* src, SkColorSpace* dst);
- const SkMatrix44& srcToDst() { return fSrcToDst; }
+ const float* srcToDst() { return fSrcToDst; }
private:
- SkMatrix44 fSrcToDst;
+ // We store the column-major form of the srcToDst matrix, for easy uploading to uniforms
+ float fSrcToDst[16];
};
#endif
« no previous file with comments | « no previous file | src/gpu/GrColorSpaceXform.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698