cc: Move LayerTreeHostCommonTest harness into the LTHCommon tests file

cc: Move LayerTreeHostCommonTest harness into the LTHCommon tests file

This moves the tests baseclass into the file where the tests live, so
we don't have test base classes living in cc/test/. This is done because
base classes separate from the tests themselves is confusing to people
trying to write new tests, there's just so many LayerTreeHost* type
things in cc/test/ that it's unclear what to use.

This resulted in the duplication of (part of) one function into
LayerTreeImplTest to ExecuteCalculateDrawProperties().

Also delete some an unused class, MockContentLayerClient, and an unused
macro. And remove the EXPECT_IDEAL_CONTENT_SCALE macro, just using
EXPECT_FLOAT_EQ instead as the macro has become a very simple proxy.

I intend to make these suites stop inheriting from the
LayerTestCommon::LayerImplTest class also, as it is meant to be used
as composition not inheritence.

R=ajuma@chromium.org, jaydasika@chromium.org
BUG=630754
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/59931941b4a767b78269fa0d1d5fccbba76158c3
Cr-Commit-Position: refs/heads/master@{#407929}

[danakj, 2016-07-26 01:57:49]

Description was changed from

==========
cc: Move LayerTreeHostCommonTest harness into the LTHCommon tests file

This moves the tests baseclass into the file where the tests live, so
we don't have test base classes living in cc/test/. This is done because
base classes separate from the tests themselves is confusing to people
trying to write new tests, there's just so many LayerTreeHost* type
things in cc/test/ that it's unclear what to use.

This resulted in the duplication of (part of) one function into
LayerTreeImplTest to ExecuteCalculateDrawProperties().

Also delete some an unused class, MockContentLayerClient, and an unused
macro. And remove the EXPECT_IDEAL_CONTENT_SCALE macro, just using
EXPECT_FLOAT_EQ instead as the macro has become a very simple proxy.

I intend to make these suites stop inheriting from the
LayerTestCommon::LayerImplTest class also, as it is meant to be used
as composition not inheritence.

R=ajuma@chromium.org, jaydasika@chromium.org
BUG=630754
==========

to

==========
cc: Move LayerTreeHostCommonTest harness into the LTHCommon tests file

This moves the tests baseclass into the file where the tests live, so
we don't have test base classes living in cc/test/. This is done because
base classes separate from the tests themselves is confusing to people
trying to write new tests, there's just so many LayerTreeHost* type
things in cc/test/ that it's unclear what to use.

This resulted in the duplication of (part of) one function into
LayerTreeImplTest to ExecuteCalculateDrawProperties().

Also delete some an unused class, MockContentLayerClient, and an unused
macro. And remove the EXPECT_IDEAL_CONTENT_SCALE macro, just using
EXPECT_FLOAT_EQ instead as the macro has become a very simple proxy.

I intend to make these suites stop inheriting from the
LayerTestCommon::LayerImplTest class also, as it is meant to be used
as composition not inheritence.

R=ajuma@chromium.org, jaydasika@chromium.org
BUG=630754
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[danakj, 2016-07-26 01:57:55]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 01:58:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 02:00:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 02:00:03]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-07-26 02:12:31]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 02:12:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 02:14:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 02:14:46]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[danakj, 2016-07-26 02:20:14]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 02:20:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 02:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 02:21:59]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[ajuma, 2016-07-26 15:08:21]

lgtm

https://codereview.chromium.org/2185463002/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2185463002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:109: gfx::Transform identity_matrix;
This seems to be unused.

https://codereview.chromium.org/2185463002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:137: gfx::Transform identity_matrix;
This one too.

https://codereview.chromium.org/2185463002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:250: gfx::Transform identity_matrix;
And here.

[danakj, 2016-07-26 19:36:36]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 19:37:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-07-26 19:37:09]

https://codereview.chromium.org/2185463002/diff/40001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2185463002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:109: gfx::Transform identity_matrix;
On 2016/07/26 15:08:21, ajuma wrote:
> This seems to be unused.

Oh thanks all Done.

[danakj, 2016-07-26 19:37:33]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-07-26 19:37:33]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2185463002/#ps60001
(title: "lthcommontest-harness3: rebase")

[commit-bot: I haz the power, 2016-07-26 19:37:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:12:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-26 22:16:20]

Description was changed from

==========
cc: Move LayerTreeHostCommonTest harness into the LTHCommon tests file

This moves the tests baseclass into the file where the tests live, so
we don't have test base classes living in cc/test/. This is done because
base classes separate from the tests themselves is confusing to people
trying to write new tests, there's just so many LayerTreeHost* type
things in cc/test/ that it's unclear what to use.

This resulted in the duplication of (part of) one function into
LayerTreeImplTest to ExecuteCalculateDrawProperties().

Also delete some an unused class, MockContentLayerClient, and an unused
macro. And remove the EXPECT_IDEAL_CONTENT_SCALE macro, just using
EXPECT_FLOAT_EQ instead as the macro has become a very simple proxy.

I intend to make these suites stop inheriting from the
LayerTestCommon::LayerImplTest class also, as it is meant to be used
as composition not inheritence.

R=ajuma@chromium.org, jaydasika@chromium.org
BUG=630754
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move LayerTreeHostCommonTest harness into the LTHCommon tests file

This moves the tests baseclass into the file where the tests live, so
we don't have test base classes living in cc/test/. This is done because
base classes separate from the tests themselves is confusing to people
trying to write new tests, there's just so many LayerTreeHost* type
things in cc/test/ that it's unclear what to use.

This resulted in the duplication of (part of) one function into
LayerTreeImplTest to ExecuteCalculateDrawProperties().

Also delete some an unused class, MockContentLayerClient, and an unused
macro. And remove the EXPECT_IDEAL_CONTENT_SCALE macro, just using
EXPECT_FLOAT_EQ instead as the macro has become a very simple proxy.

I intend to make these suites stop inheriting from the
LayerTestCommon::LayerImplTest class also, as it is meant to be used
as composition not inheritence.

R=ajuma@chromium.org, jaydasika@chromium.org
BUG=630754
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/59931941b4a767b78269fa0d1d5fccbba76158c3
Cr-Commit-Position: refs/heads/master@{#407929}
==========

[commit-bot: I haz the power, 2016-07-26 22:16:21]

Patchset 4 (id:??) landed as
https://crrev.com/59931941b4a767b78269fa0d1d5fccbba76158c3
Cr-Commit-Position: refs/heads/master@{#407929}