Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2181763005: cc: Make LayerTreeImpl tests stop subclassing LayerImplTest. (Closed)

Created:
4 years, 4 months ago by danakj
Modified:
4 years, 4 months ago
Reviewers:
jaydasika, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@lthcommontest-harness3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make LayerTreeImpl tests stop subclassing LayerImplTest. This class is meant for composition not inheritance. R=ajuma, jaydasika@chromium.org BUG=630754 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/76ddc8770c3b80af44f97ddaa32d14098beb0ff8 Cr-Commit-Position: refs/heads/master@{#407961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -250 lines) Patch
M cc/test/layer_test_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 67 chunks +129 lines, -249 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
danakj
4 years, 4 months ago (2016-07-26 21:38:57 UTC) #3
jaydasika
lgtm
4 years, 4 months ago (2016-07-26 22:39:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181763005/1
4 years, 4 months ago (2016-07-26 22:42:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 23:21:57 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 23:23:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76ddc8770c3b80af44f97ddaa32d14098beb0ff8
Cr-Commit-Position: refs/heads/master@{#407961}

Powered by Google App Engine
This is Rietveld 408576698