Display USB devices in the site settings popup on Android.

Display USB devices in the site settings popup on Android.

This patch adds USB devices (and any other type of chosen object that is
defined in the future such as Bluetooth devices) to the list of
permissions displayed in the site settings popup on Android that is
displayed when the site icon is tapped.

BUG=601627
Committed: https://crrev.com/58f82ab510dc67bbf55c60f99abe8e1339534c19
Cr-Commit-Position: refs/heads/master@{#409425}

[Reilly Grant (use Gerrit), 2016-07-27 22:46:31]

reillyg@chromium.org changed reviewers:
+ benwells@chromium.org, twellington@chromium.org, yfriedman@chromium.org

[Reilly Grant (use Gerrit), 2016-07-27 22:46:32]

Please take a look.

twellington@ for //chrome/android
yfriedman@ for //chrome/browser/ui/android
benwells@ for //chrome/browser/ui/website_settings

[Reilly Grant (use Gerrit), 2016-07-27 22:46:44]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 22:47:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 23:25:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 23:25:13]

Dry run: This issue passed the CQ dry run.

[benwells, 2016-07-28 07:51:13]

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:204:
{CONTENT_SETTINGS_TYPE_USB_CHOOSER_DATA, &GetUsbChooserContext,
Is there a plan to remove this USB specific code from this file? It is wrong to
have it here.

[Reilly Grant (use Gerrit), 2016-07-28 17:55:43]

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:204:
{CONTENT_SETTINGS_TYPE_USB_CHOOSER_DATA, &GetUsbChooserContext,
On 2016/07/28 at 07:51:13, benwells wrote:
> Is there a plan to remove this USB specific code from this file? It is wrong
to have it here.

Can you explain why it is wrong to have this here? There is specific code for
every permission in this file.

[Theresa, 2016-07-28 18:21:12]

chrome/android/ lgtm

[benwells, 2016-07-29 05:01:39]

lgtm

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:204:
{CONTENT_SETTINGS_TYPE_USB_CHOOSER_DATA, &GetUsbChooserContext,
On 2016/07/28 17:55:43, Reilly Grant wrote:
> On 2016/07/28 at 07:51:13, benwells wrote:
> > Is there a plan to remove this USB specific code from this file? It is wrong
> to have it here.
> 
> Can you explain why it is wrong to have this here? There is specific code for
> every permission in this file.

OK, my bad, I got a bit mixed up.

[Yaron, 2016-08-01 02:22:58]

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/android/w...
File chrome/browser/ui/android/website_settings_popup_android.cc (left):

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/android/w...
chrome/browser/ui/android/website_settings_popup_android.cc:98:
STLDeleteContainerPointers(chosen_object_info_list.begin(),
these should still be freed at the end, shouldn't they? Everything in java is a
copy

[Reilly Grant (use Gerrit), 2016-08-01 19:00:43]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2016-08-01 19:00:49]

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/android/w...
File chrome/browser/ui/android/website_settings_popup_android.cc (left):

https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/android/w...
chrome/browser/ui/android/website_settings_popup_android.cc:98:
STLDeleteContainerPointers(chosen_object_info_list.begin(),
On 2016/08/01 at 02:22:58, Yaron (OOO) wrote:
> these should still be freed at the end, shouldn't they? Everything in java is
a copy

You're right. Thanks.

[commit-bot: I haz the power, 2016-08-01 19:01:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 19:49:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 19:49:17]

Dry run: This issue passed the CQ dry run.

[Yaron, 2016-08-03 00:48:02]

On 2016/08/01 19:00:49, Reilly Grant wrote:
>
https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/android/w...
> File chrome/browser/ui/android/website_settings_popup_android.cc (left):
> 
>
https://codereview.chromium.org/2185213002/diff/1/chrome/browser/ui/android/w...
> chrome/browser/ui/android/website_settings_popup_android.cc:98:
> STLDeleteContainerPointers(chosen_object_info_list.begin(),
> On 2016/08/01 at 02:22:58, Yaron (OOO) wrote:
> > these should still be freed at the end, shouldn't they? Everything in java
is
> a copy
> 
> You're right. Thanks.

lgtm (I'm ooo for realz now so follow-ups will need to be with someone else ;)

[Reilly Grant (use Gerrit), 2016-08-03 00:56:03]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-08-03 00:56:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2185213002/#ps20001
(title: "Replaced code to free chosen objects.")

[commit-bot: I haz the power, 2016-08-03 00:56:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 01:50:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 01:53:06]

Description was changed from

==========
Display USB devices in the site settings popup on Android.

This patch adds USB devices (and any other type of chosen object that is
defined in the future such as Bluetooth devices) to the list of
permissions displayed in the site settings popup on Android that is
displayed when the site icon is tapped.

BUG=601627
==========

to

==========
Display USB devices in the site settings popup on Android.

This patch adds USB devices (and any other type of chosen object that is
defined in the future such as Bluetooth devices) to the list of
permissions displayed in the site settings popup on Android that is
displayed when the site icon is tapped.

BUG=601627

Committed: https://crrev.com/58f82ab510dc67bbf55c60f99abe8e1339534c19
Cr-Commit-Position: refs/heads/master@{#409425}
==========

[commit-bot: I haz the power, 2016-08-03 01:53:07]

Patchset 2 (id:??) landed as
https://crrev.com/58f82ab510dc67bbf55c60f99abe8e1339534c19
Cr-Commit-Position: refs/heads/master@{#409425}