Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7451)

Unified Diff: chrome/browser/ui/android/website_settings_popup_android.cc

Issue 2185213002: Display USB devices in the site settings popup on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replaced code to free chosen objects. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/website_settings_popup_android.cc
diff --git a/chrome/browser/ui/android/website_settings_popup_android.cc b/chrome/browser/ui/android/website_settings_popup_android.cc
index 75b5e48c7fa677b1f042d16144e9d9bba4efe90e..0706ef7e8a93fd9ec03b61a220a5b3edb846006a 100644
--- a/chrome/browser/ui/android/website_settings_popup_android.cc
+++ b/chrome/browser/ui/android/website_settings_popup_android.cc
@@ -93,11 +93,6 @@ void WebsiteSettingsPopupAndroid::SetCookieInfo(
void WebsiteSettingsPopupAndroid::SetPermissionInfo(
const PermissionInfoList& permission_info_list,
const ChosenObjectInfoList& chosen_object_info_list) {
- // TODO(reillyg): Display the contents of |chosen_object_info_list|.
- // https://crbug.com/424667.
- STLDeleteContainerPointers(chosen_object_info_list.begin(),
- chosen_object_info_list.end());
-
JNIEnv* env = base::android::AttachCurrentThread();
// On Android, we only want to display a subset of the available options in a
@@ -136,6 +131,18 @@ void WebsiteSettingsPopupAndroid::SetPermissionInfo(
}
}
+ for (auto* chosen_object : chosen_object_info_list) {
+ base::string16 object_title =
+ WebsiteSettingsUI::ChosenObjectToUIString(*chosen_object);
+
+ Java_WebsiteSettingsPopup_addPermissionSection(
+ env, popup_jobject_.obj(),
+ ConvertUTF16ToJavaString(env, object_title).obj(),
+ static_cast<jint>(chosen_object->ui_info.content_settings_type),
+ static_cast<jint>(CONTENT_SETTING_ALLOW));
+ delete chosen_object;
+ }
+
Java_WebsiteSettingsPopup_updatePermissionDisplay(env, popup_jobject_.obj());
}

Powered by Google App Engine
This is Rietveld 408576698