Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2185163003: make use of existing gn args in ui build config (Closed)

Created:
4 years, 4 months ago by Mostyn Bramley-Moore
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, tdresser+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

make use of existing gn args in ui build config BUG=632297 Committed: https://crrev.com/2a395c69f43be191344cb9b198fe8e77f6c4bd17 Cr-Commit-Position: refs/heads/master@{#409203}

Patch Set 1 #

Patch Set 2 : typo fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M build/config/ui.gni View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 2 chunks +9 lines, -2 lines 0 comments Download
M ui/events/BUILD.gn View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Mostyn Bramley-Moore
@brettw: please take a look at this GN cleanup.
4 years, 4 months ago (2016-07-27 22:44:15 UTC) #4
Mostyn Bramley-Moore
The android_arm64_dbg_recipe failure looks unrelated- it fails both with and without this patch.
4 years, 4 months ago (2016-07-27 23:21:26 UTC) #11
brettw
lgtm
4 years, 4 months ago (2016-08-01 18:21:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185163003/20001
4 years, 4 months ago (2016-08-02 14:57:29 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 16:12:44 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 16:14:55 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a395c69f43be191344cb9b198fe8e77f6c4bd17
Cr-Commit-Position: refs/heads/master@{#409203}

Powered by Google App Engine
This is Rietveld 408576698