Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Side by Side Diff: build/config/ui.gni

Issue 2185163003: make use of existing gn args in ui build config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo fixup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains UI-related build flags (see features.gni for Chrome 5 # This file contains UI-related build flags (see features.gni for Chrome
6 # feature-related ones). These should theoretically be moved to the ui 6 # feature-related ones). These should theoretically be moved to the ui
7 # directory. 7 # directory.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global to match the GYP configuration. Also, 10 # e.g. base, so they need to be global to match the GYP configuration. Also,
11 # anything that needs a grit define must be in either this file or features.gni. 11 # anything that needs a grit define must be in either this file or features.gni.
12 # 12 #
13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't 13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't
14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how 14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how
15 # to set up feature flags. 15 # to set up feature flags.
16 16
17 import("//build/config/chromecast_build.gni") 17 import("//build/config/chromecast_build.gni")
18 import("//build/config/features.gni")
18 19
19 declare_args() { 20 declare_args() {
20 # Indicates if Ash is enabled. Ash is the Aura Shell which provides a 21 # Indicates if Ash is enabled. Ash is the Aura Shell which provides a
21 # desktop-like environment for Aura. Requires use_aura = true 22 # desktop-like environment for Aura. Requires use_aura = true
22 use_ash = is_chromeos && !is_chromecast 23 use_ash = is_chromeos && !is_chromecast
23 24
24 # Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux 25 # Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux
25 # that does not require X11. Enabling this feature disables use of glib, x11, 26 # that does not require X11. Enabling this feature disables use of glib, x11,
26 # Pango, and Cairo. Default to false on non-Chromecast builds. 27 # Pango, and Cairo. Default to false on non-Chromecast builds.
27 use_ozone = is_chromecast && !is_android 28 use_ozone = is_chromecast && !is_android
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 77
77 if (is_linux && !use_ozone) { 78 if (is_linux && !use_ozone) {
78 use_cairo = true 79 use_cairo = true
79 use_pango = true 80 use_pango = true
80 } else { 81 } else {
81 use_cairo = false 82 use_cairo = false
82 use_pango = false 83 use_pango = false
83 } 84 }
84 85
85 # Whether to use atk, the Accessibility ToolKit library 86 # Whether to use atk, the Accessibility ToolKit library
86 use_atk = is_desktop_linux && use_x11 87 use_atk = is_desktop_linux && use_x11 && use_gconf
87 88
88 use_clipboard_aurax11 = 89 use_clipboard_aurax11 =
89 (is_desktop_linux && use_aura && use_x11) || enable_clipboard_aurax11 90 (is_desktop_linux && use_aura && use_x11) || enable_clipboard_aurax11
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698