Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 2185153003: gpu: Avoid creating two native pixmaps for the same buffer. (Closed)

Created:
4 years, 4 months ago by reveman
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

gpu: Avoid creating two native pixmaps for the same buffer. For buffers allocated using CreateGpuMemoryBuffer, avoid creating a second native pixmap for the same buffer as that results in the associated GEM handle being closed twice. BUG=631268 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2188893002 Cr-Commit-Position: refs/heads/master@{#408268} (cherry picked from commit 770b48e9e2c1e9d47b0c2a02c767a370b0adb3da) Committed: https://chromium.googlesource.com/chromium/src/+/884189216f6a41a4bd49c43fe569a01b800150df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc View 1 chunk +23 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
reveman
4 years, 4 months ago (2016-07-27 23:48:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
884189216f6a41a4bd49c43fe569a01b800150df.

Powered by Google App Engine
This is Rietveld 408576698