gpu: Avoid creating two native pixmaps for the same buffer.

gpu: Avoid creating two native pixmaps for the same buffer.

For buffers allocated using CreateGpuMemoryBuffer, avoid
creating a second native pixmap for the same buffer as that
results in the associated GEM handle being closed twice.

BUG=631268
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/770b48e9e2c1e9d47b0c2a02c767a370b0adb3da
Cr-Commit-Position: refs/heads/master@{#408268}

[reveman, 2016-07-27 22:28:51]

Description was changed from

==========
gpu: Avoid creating two native pixmaps for the same buffer.

For buffers allocated using CreateGpuMemoryBuffer, avoid
creating a second native pixmap for the same buffer as that
results in the associated GEM handle being closed twice.

BUG=631268
==========

to

==========
gpu: Avoid creating two native pixmaps for the same buffer.

For buffers allocated using CreateGpuMemoryBuffer, avoid
creating a second native pixmap for the same buffer as that
results in the associated GEM handle being closed twice.

BUG=631268
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[reveman, 2016-07-27 22:29:11]

reveman@chromium.org changed reviewers:
+ piman@chromium.org

[reveman, 2016-07-27 22:35:53]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 22:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-27 22:42:14]

LGTM, with a possible follow-up.

https://codereview.chromium.org/2188893002/diff/1/gpu/ipc/service/gpu_memory_...
File gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2188893002/diff/1/gpu/ipc/service/gpu_memory_...
gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc:100: }
Should we add pixmap to the map in this case, so that we reuse it if we call
this again (e.g. for another context/process for any reason)?

[reveman, 2016-07-27 23:13:25]

https://codereview.chromium.org/2188893002/diff/1/gpu/ipc/service/gpu_memory_...
File gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc (right):

https://codereview.chromium.org/2188893002/diff/1/gpu/ipc/service/gpu_memory_...
gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc:100: }
On 2016/07/27 at 22:42:14, piman - slow reviews until 8-8 wrote:
> Should we add pixmap to the map in this case, so that we reuse it if we call
this again (e.g. for another context/process for any reason)?

The client is in control over handle.id in this case and that can cause an issue
if the client uses this to add a pixmap that will cause the DCHECK at line 50 to
fail. It might still be a good idea to do something like what you're suggesting
though or add some GEM handle tracking mechanism at a lower level. I'm going to
land this for now and look at what is the best long term solution as a follow
up.

[reveman, 2016-07-27 23:13:57]

The CQ bit was unchecked by reveman@chromium.org

[reveman, 2016-07-27 23:14:00]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2016-07-27 23:14:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 23:17:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-27 23:19:51]

Description was changed from

==========
gpu: Avoid creating two native pixmaps for the same buffer.

For buffers allocated using CreateGpuMemoryBuffer, avoid
creating a second native pixmap for the same buffer as that
results in the associated GEM handle being closed twice.

BUG=631268
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Avoid creating two native pixmaps for the same buffer.

For buffers allocated using CreateGpuMemoryBuffer, avoid
creating a second native pixmap for the same buffer as that
results in the associated GEM handle being closed twice.

BUG=631268
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/770b48e9e2c1e9d47b0c2a02c767a370b0adb3da
Cr-Commit-Position: refs/heads/master@{#408268}
==========

[commit-bot: I haz the power, 2016-07-27 23:19:51]

Patchset 1 (id:??) landed as
https://crrev.com/770b48e9e2c1e9d47b0c2a02c767a370b0adb3da
Cr-Commit-Position: refs/heads/master@{#408268}