require semi at the end of SkASSERT and friends

require semi at the end of SkASSERT and friends

R=bungeman@google.com
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185063002

Committed: https://skia.googlesource.com/skia/+/d6562000efca50bc2bfddae8dcb69dce6b8c0950

[caryclark, 2016-07-27 15:45:54]

Description was changed from

==========
require semi at the end of SkASSERT and friends

R=bungeman@google.com
TBR=reed@google.com
==========

to

==========
require semi at the end of SkASSERT and friends

R=bungeman@google.com
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185063002
==========

[caryclark, 2016-07-27 15:47:39]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 15:47:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 15:48:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 15:48:56]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[caryclark, 2016-07-27 16:27:01]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 16:27:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 17:11:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 17:11:47]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-07-27 17:14:53]

lgtm, with suggestion for possible factoring.

https://codereview.chromium.org/2185063002/diff/20001/include/core/SkTypes.h
File include/core/SkTypes.h (right):

https://codereview.chromium.org/2185063002/diff/20001/include/core/SkTypes.h#...
include/core/SkTypes.h:158: } while (false)
For the number of times we use this (here and elsewhere) seems it would be nice
to have something like

#define SkREQUIRE_SEMICOLON_AFTER(code) do { code } while (false)

[caryclark, 2016-07-27 17:55:29]

On 2016/07/27 17:14:53, bungeman-skia wrote:
> lgtm, with suggestion for possible factoring.
> 
> https://codereview.chromium.org/2185063002/diff/20001/include/core/SkTypes.h
> File include/core/SkTypes.h (right):
> 
>
https://codereview.chromium.org/2185063002/diff/20001/include/core/SkTypes.h#...
> include/core/SkTypes.h:158: } while (false)
> For the number of times we use this (here and elsewhere) seems it would be
nice
> to have something like
> 
> #define SkREQUIRE_SEMICOLON_AFTER(code) do { code } while (false)

Done

[caryclark, 2016-07-27 17:55:34]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 17:55:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-07-27 18:57:00]

Looks even better to me (I think that's spelled LGTM!!! or something like that).

[commit-bot: I haz the power, 2016-07-27 18:59:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 18:59:51]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-07-27 19:01:00]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-07-27 19:01:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 19:02:09]

Description was changed from

==========
require semi at the end of SkASSERT and friends

R=bungeman@google.com
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185063002
==========

to

==========
require semi at the end of SkASSERT and friends

R=bungeman@google.com
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185063002

Committed:
https://skia.googlesource.com/skia/+/d6562000efca50bc2bfddae8dcb69dce6b8c0950
==========

[commit-bot: I haz the power, 2016-07-27 19:02:12]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d6562000efca50bc2bfddae8dcb69dce6b8c0950