services/ui/public/cpp/gpu_service.h - Issue 2184943002: services/ui: Move some files into the client lib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/public/cpp/gpu_service.h

Issue 2184943002: services/ui: Move some files into the client lib. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrome-gpu-in-mus-windows

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/ui/public/cpp/BUILD.gn ('k') | services/ui/public/cpp/lib/command_buffer_client_impl.cc » ('j') | services/ui/public/cpp/lib/gpu_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/ui/public/cpp/gpu_service.h

diff --git a/services/ui/common/gpu_service.h b/services/ui/public/cpp/gpu_service.h

similarity index 88%

rename from services/ui/common/gpu_service.h

rename to services/ui/public/cpp/gpu_service.h

index 7308754eac55f45c1c5ac0d7b234f8e75e16e9cd..2bb3b0b3732e74c8de217e7ef22150297a637ee5 100644

--- a/services/ui/common/gpu_service.h

+++ b/services/ui/public/cpp/gpu_service.h

@@ -2,8 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef SERVICES_UI_COMMON_GPU_SERVICE_H_

-#define SERVICES_UI_COMMON_GPU_SERVICE_H_

+#ifndef SERVICES_UI_PUBLIC_CPP_GPU_SERVICE_H_

+#define SERVICES_UI_PUBLIC_CPP_GPU_SERVICE_H_

#include <stdint.h>

#include <vector>

@@ -15,8 +15,8 @@

#include "base/synchronization/waitable_event.h"

#include "base/threading/thread.h"

#include "gpu/ipc/client/gpu_channel_host.h"

-#include "services/ui/common/mojo_gpu_memory_buffer_manager.h"

-#include "services/ui/common/mus_common_export.h"

+#include "services/ui/public/cpp/mojo_gpu_memory_buffer_manager.h"

+#include "services/ui/public/cpp/ui_export.h"

#include "services/ui/public/interfaces/gpu_service.mojom.h"

namespace shell {

@@ -25,7 +25,7 @@ class Connector;

namespace ui {

-class MUS_COMMON_EXPORT GpuService : public gpu::GpuChannelHostFactory {

+class UI_EXPORT GpuService : public gpu::GpuChannelHostFactory {

Peng 2016/07/28 13:02:29 UI_EXPORT? Seems client library will be a shared l

public:

void EstablishGpuChannel(const base::Closure& callback);

scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync();

@@ -81,4 +81,4 @@ class MUS_COMMON_EXPORT GpuService : public gpu::GpuChannelHostFactory {

} // namespace ui

-#endif // COMPONENTS_MUS_PUBLIC_CPP_LIB_GPU_SERVICE_CONNECTION_H_

+#endif // SERVICES_UI_PUBLIC_CPP_GPU_SERVICE_H_

« no previous file with comments | « services/ui/public/cpp/BUILD.gn ('k') | services/ui/public/cpp/lib/command_buffer_client_impl.cc » ('j') | services/ui/public/cpp/lib/gpu_service.cc » ('J')