Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2184913002: google_apis: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
CC:
chromium-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

google_apis: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=rogerta@chromium.org BUG=554600 Committed: https://crrev.com/3d26e74634a9470e3ac06911ee899ce0ffc06339 Cr-Commit-Position: refs/heads/master@{#408195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M google_apis/drive/drive_api_requests.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-27 00:33:22 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
4 years, 4 months ago (2016-07-27 15:42:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184913002/1
4 years, 4 months ago (2016-07-27 17:46:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 18:34:11 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 18:37:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d26e74634a9470e3ac06911ee899ce0ffc06339
Cr-Commit-Position: refs/heads/master@{#408195}

Powered by Google App Engine
This is Rietveld 408576698