Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: google_apis/drive/drive_api_requests.cc

Issue 2184913002: google_apis: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/gaia/gaia_auth_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/drive/drive_api_requests.cc
diff --git a/google_apis/drive/drive_api_requests.cc b/google_apis/drive/drive_api_requests.cc
index eefaa3594b771ff1a80d7dbb6e9d6b3fd40a4e64..4e622a8969dc24b4ca7a2a76d85c1a0c74dea37a 100644
--- a/google_apis/drive/drive_api_requests.cc
+++ b/google_apis/drive/drive_api_requests.cc
@@ -1282,7 +1282,7 @@ ScopedVector<BatchUploadChildEntry>::iterator BatchUploadRequest::GetChildEntry(
void BatchUploadRequest::MayCompletePrepare() {
if (!committed_ || prepare_callback_.is_null())
return;
- for (const auto& child : child_requests_) {
+ for (auto* child : child_requests_) {
if (!child->prepared)
return;
}
@@ -1290,7 +1290,7 @@ void BatchUploadRequest::MayCompletePrepare() {
// Build multipart body here.
int64_t total_size = 0;
std::vector<ContentTypeAndData> parts;
- for (auto& child : child_requests_) {
+ for (auto* child : child_requests_) {
std::string type;
std::string data;
const bool result = child->request->GetContentData(&type, &data);
@@ -1402,7 +1402,7 @@ void BatchUploadRequest::ProcessURLFetchResults(const net::URLFetcher* source) {
}
void BatchUploadRequest::RunCallbackOnPrematureFailure(DriveApiErrorCode code) {
- for (auto& child : child_requests_)
+ for (auto* child : child_requests_)
child->request->NotifyError(code);
child_requests_.clear();
}
@@ -1410,7 +1410,7 @@ void BatchUploadRequest::RunCallbackOnPrematureFailure(DriveApiErrorCode code) {
void BatchUploadRequest::OnURLFetchUploadProgress(const net::URLFetcher* source,
int64_t current,
int64_t total) {
- for (auto& child : child_requests_) {
+ for (auto* child : child_requests_) {
if (child->data_offset <= current &&
current <= child->data_offset + child->data_size) {
child->request->NotifyUploadProgress(source, current - child->data_offset,
« no previous file with comments | « no previous file | google_apis/gaia/gaia_auth_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698