Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4917)

Unified Diff: chrome/browser/resources/settings/device_page/device_page.js

Issue 2184893002: Settings Router Refactor: Remove route.page legacy property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0217-settings-refactor-settings-menu
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/device_page.js
diff --git a/chrome/browser/resources/settings/device_page/device_page.js b/chrome/browser/resources/settings/device_page/device_page.js
index 76c0c208ebcc429a665c75cb1f09659900383065..74f17a0d6dde89c2bdcf70e072b8a600744511fc 100644
--- a/chrome/browser/resources/settings/device_page/device_page.js
+++ b/chrome/browser/resources/settings/device_page/device_page.js
@@ -134,10 +134,6 @@ Polymer({
* @private
*/
isCurrentRouteOnPointersPage_: function() {
- return this.currentRoute &&
- this.currentRoute.page == 'basic' &&
- this.currentRoute.section == 'device' &&
- this.currentRoute.subpage.length == 1 &&
- this.currentRoute.subpage[0] == 'pointers';
+ return this.currentRoute == settings.Route.POINTERS;
michaelpg 2016/07/28 23:22:31 meh, optionally: just inline this -- it's literall
tommycli 2016/07/29 00:03:35 Done.
},
});

Powered by Google App Engine
This is Rietveld 408576698