chrome/browser/resources/settings/basic_page/basic_page.html - Issue 2184893002: Settings Router Refactor: Remove route.page legacy property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 2184893002: Settings Router Refactor: Remove route.page legacy property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0217-settings-refactor-settings-menu

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/advanced_page/advanced_page.html ('k') | chrome/browser/resources/settings/device_page/device_page.js » ('j') | chrome/browser/resources/settings/device_page/device_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/basic_page/basic_page.html

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.html b/chrome/browser/resources/settings/basic_page/basic_page.html

index b8cf49b5fb7b149787007a33723a44413d6eb364..625143db6741a4e590e008cd73918cde2f7c3add 100644

--- a/chrome/browser/resources/settings/basic_page/basic_page.html

+++ b/chrome/browser/resources/settings/basic_page/basic_page.html

@@ -22,7 +22,7 @@

<dom-module id="settings-basic-page">

- <div data-page="basic">

+ <div>

<settings-reset-profile-banner on-reset-done="onResetDone_">

</settings-reset-profile-banner>