chrome/browser/resources/settings/settings_page_css.html - Issue 2184863002: MD Settings: Remove paper-header-panel, use IntersectionObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page_css.html

Issue 2184863002: MD Settings: Remove paper-header-panel, use IntersectionObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page/main_page_behavior.js ('k') | chrome/browser/resources/settings/settings_ui/settings_ui.html » ('j') | chrome/browser/resources/settings/settings_ui/settings_ui.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page_css.html

diff --git a/chrome/browser/resources/settings/settings_page_css.html b/chrome/browser/resources/settings/settings_page_css.html

index 6aa289ef18703913b9e2540e76b1b80d61af3b2a..e26e9d7e9955c50bcb25592796cf706036087bf3 100644

--- a/chrome/browser/resources/settings/settings_page_css.html

+++ b/chrome/browser/resources/settings/settings_page_css.html

@@ -15,15 +15,13 @@

width: 96%;

}

- :host(.showing-subpage) {

+ :host(.showing-subpage),

+ :host(.showing-subpage) #basicPage,

+ :host(.showing-subpage) #advancedPage {

/* The subpage container should extend to the bottom of the page. */

height: 100%;

}

- :host > div {

- height: inherit;

- }

:host > div > :not(.expanded) {

/* The margin and padding here are doing two things: make the total

* separation 24px; and make scrollIntoView align the section header