chrome/browser/resources/settings/settings_page/main_page_behavior.js - Issue 2184863002: MD Settings: Remove paper-header-panel, use IntersectionObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2184863002: MD Settings: Remove paper-header-panel, use IntersectionObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_page_css.html » ('j') | chrome/browser/resources/settings/settings_ui/settings_ui.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js

diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

index 56a74cd96cb0047f12135631c2edd43fc828ab8b..5d125a43f14594a00087beb32d5968c4fcdb0f66 100644

--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js

+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

@@ -41,10 +41,7 @@ var MainPageBehaviorImpl = {

/** @override */

attached: function() {

- if (this.domHost && this.domHost.parentNode.tagName == 'PAPER-HEADER-PANEL')

- this.scroller = this.domHost.parentNode.scroller;

- else

- this.scroller = document.body; // Used in unit tests.

+ this.scroller = this.domHost ? this.domHost.parentNode : document.body;

/**

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_page_css.html » ('j') | chrome/browser/resources/settings/settings_ui/settings_ui.html » ('J')