Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Issue 2184773002: cc: Move blend_mode to the effect tree (Closed)

Created:
4 years, 4 months ago by ajuma
Modified:
4 years, 4 months ago
Reviewers:
jaydasika, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move blend_mode to the effect tree This removes blend_mode from LayerImpl, and adds it to the effect tree and to LayerImplTestProperties. BUG=611883 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/4c14b256d8b2b7b3196f246437a9a67f641b980b Cr-Commit-Position: refs/heads/master@{#407896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -40 lines) Patch
M cc/layers/layer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/layer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer_impl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M cc/layers/layer_impl.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M cc/layers/layer_impl_test_properties.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layers/layer_impl_test_properties.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 5 chunks +0 lines, -8 lines 0 comments Download
M cc/layers/render_surface_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/proto/property_tree.proto View 2 chunks +3 lines, -1 line 0 comments Download
M cc/trees/effect_node.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/effect_node.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/occlusion_tracker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/property_tree_builder.cc View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
ajuma
4 years, 4 months ago (2016-07-26 18:13:43 UTC) #8
jaydasika
lgtm
4 years, 4 months ago (2016-07-26 18:55:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184773002/1
4 years, 4 months ago (2016-07-26 20:05:31 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 20:11:15 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:14:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c14b256d8b2b7b3196f246437a9a67f641b980b
Cr-Commit-Position: refs/heads/master@{#407896}

Powered by Google App Engine
This is Rietveld 408576698