Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2184553003: Revert of [interpreter] Add explicit OSR polling bytecode. (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-osr-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter] Add explicit OSR polling bytecode. (patchset #6 id:100001 of https://codereview.chromium.org/2172233002/ ) Reason for revert: Bunch of breakages. Maybe bad interaction with https://chromium.googlesource.com/v8/v8/+/e520e5da5550f0d1a975e87d6e66a2edecbb0c8e ? E.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/11607 Original issue's description: > [interpreter] Add explicit OSR polling bytecode. > > This adds an explicit {OsrPoll} bytecode into every loop header which > triggers on-stack replacement when armed. Note that each such bytecode > stores the static loop depths as an operand, and hence can be armed for > specific loop depths. > > This also adds builtin code that triggers OSR compilation and switches > execution over to optimized code in case compilation succeeds. In case > compilation fails, the bytecode dispatch just continues unhindered. > > R=rmcilroy@chromium.org > TEST=mjsunit/ignition/osr-from-bytecode > BUG=v8:4764 > > Committed: https://crrev.com/a55beb68e0ededb3773affa294a71edc50621458 > Cr-Commit-Position: refs/heads/master@{#38043} TBR=rmcilroy@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4764 Committed: https://crrev.com/439aa2c6d708bfd95db725bd6f97c4c49bbc51fc Cr-Commit-Position: refs/heads/master@{#38044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -305 lines) Patch
M src/builtins/arm/builtins-arm.cc View 3 chunks +3 lines, -24 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 3 chunks +3 lines, -24 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 3 chunks +3 lines, -24 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 3 chunks +3 lines, -24 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 3 chunks +3 lines, -24 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 3 chunks +3 lines, -24 lines 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +24 lines, -58 lines 0 comments Download
D test/mjsunit/ignition/osr-from-bytecode.js View 1 chunk +0 lines, -12 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
Created Revert of [interpreter] Add explicit OSR polling bytecode.
4 years, 4 months ago (2016-07-26 11:04:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184553003/1
4 years, 4 months ago (2016-07-26 11:04:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 11:05:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/439aa2c6d708bfd95db725bd6f97c4c49bbc51fc Cr-Commit-Position: refs/heads/master@{#38044}
4 years, 4 months ago (2016-07-26 11:07:28 UTC) #7
Michael Starzinger
4 years, 4 months ago (2016-07-26 12:52:26 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2184713002/ by mstarzinger@chromium.org.

The reason for reverting is: Fix has been landed..

Powered by Google App Engine
This is Rietveld 408576698