src/compiler.cc - Issue 2184553003: Revert of [interpreter] Add explicit OSR polling bytecode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 2184553003: Revert of [interpreter] Add explicit OSR polling bytecode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_interpreter-osr-1

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 9b59aca2e4d9da62a68b4600ce26c7db8b7f1c82..aada244f7fad8f09c7e8a772a45afaced9858dba 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -745,11 +745,6 @@

Isolate* isolate = function->GetIsolate();

Handle<SharedFunctionInfo> shared(function->shared(), isolate);

- // TODO(4764): Remove this guard once OSR graph construction works.

- if (!osr_ast_id.IsNone() && osr_frame->is_interpreted()) {

- return MaybeHandle<Code>();

- }

Handle<Code> cached_code;

if (GetCodeFromOptimizedCodeMap(function, osr_ast_id)

.ToHandle(&cached_code)) {

« no previous file with comments | « src/code-factory.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »