[turbofan] Adds handling of number or oddball type feedback to SpeculativeNumberShiftLeft.

[turbofan] Adds handling of number or oddball type feedback to SpeculativeNumberShiftLeft.

This required the introduction of the CheckedNumberOrOddballAsWord32 use info, and a change in the RepresentationChanger to handle it.

BUG=

Committed: https://crrev.com/94ab292fba494f6968d18305f77d279d81af5d22
Cr-Commit-Position: refs/heads/master@{#38086}

[epertoso, 2016-07-26 14:59:34]

Description was changed from

==========
[turbofan] Adds handling of number or oddball type feedback to
SpeculativeNumberShiftLeft.

This required the introduction of the CheckedNumberOrOddballAsWord32 use info,
and a change in the RepresentationChanger to handle it.

BUG=
==========

to

==========
[turbofan] Adds handling of number or oddball type feedback to
SpeculativeNumberShiftLeft.

This required the introduction of the CheckedNumberOrOddballAsWord32 use info,
and a change in the RepresentationChanger to handle it.

BUG=
==========

[epertoso, 2016-07-26 14:59:34]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org, jarin@chromium.org

[epertoso, 2016-07-26 14:59:34]

epertoso@chromium.org changed required reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2016-07-27 03:34:36]

LGTM once nits are addressed.

https://codereview.chromium.org/2184513003/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/2184513003/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:598: if (feedback ==
BinaryOperationHints::kSigned32 ||
Nit: use feedback != BinaryOperationHints::kAny as we do for the other reduction
rules.

https://codereview.chromium.org/2184513003/diff/1/src/compiler/representation...
File src/compiler/representation-change.cc (right):

https://codereview.chromium.org/2184513003/diff/1/src/compiler/representation...
src/compiler/representation-change.cc:484: DCHECK(use_info.type_check() ==
TypeCheckKind::kNumberOrOddball);
Nit: Use DCHECK_EQ(TypeCheckKind::kNumberOrOddball, use_info.type_check());

https://codereview.chromium.org/2184513003/diff/1/src/compiler/simplified-low...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2184513003/diff/1/src/compiler/simplified-low...
src/compiler/simplified-lowering.cc:1670: hint ==
BinaryOperationHints::kSigned32 ||
This if is redundant. Drop it completely, or phrase it as DCHECK.

[Jarin, 2016-07-27 05:34:01]

lgtm.

https://codereview.chromium.org/2184513003/diff/1/src/compiler/representation...
File src/compiler/representation-change.cc (right):

https://codereview.chromium.org/2184513003/diff/1/src/compiler/representation...
src/compiler/representation-change.cc:468: to_float_checked);
As discussed offline, we should introduce a dedicated operator that does the
checking and truncation, so that we have fast path for smis. (In a separate CL,
so not actionable now.)

https://codereview.chromium.org/2184513003/diff/1/src/compiler/simplified-low...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2184513003/diff/1/src/compiler/simplified-low...
src/compiler/simplified-lowering.cc:1670: hint ==
BinaryOperationHints::kSigned32 ||
On 2016/07/27 03:34:36, Benedikt Meurer wrote:
> This if is redundant. Drop it completely, or phrase it as DCHECK.

+1 for the DCHECK.

[epertoso, 2016-07-27 08:26:37]

https://codereview.chromium.org/2184513003/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/2184513003/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:598: if (feedback ==
BinaryOperationHints::kSigned32 ||
On 2016/07/27 03:34:36, Benedikt Meurer wrote:
> Nit: use feedback != BinaryOperationHints::kAny as we do for the other
reduction
> rules.

Done.

https://codereview.chromium.org/2184513003/diff/1/src/compiler/representation...
File src/compiler/representation-change.cc (right):

https://codereview.chromium.org/2184513003/diff/1/src/compiler/representation...
src/compiler/representation-change.cc:468: to_float_checked);
On 2016/07/27 05:34:01, Jarin wrote:
> As discussed offline, we should introduce a dedicated operator that does the
> checking and truncation, so that we have fast path for smis. (In a separate
CL,
> so not actionable now.)

Acknowledged.

https://codereview.chromium.org/2184513003/diff/1/src/compiler/representation...
src/compiler/representation-change.cc:484: DCHECK(use_info.type_check() ==
TypeCheckKind::kNumberOrOddball);
On 2016/07/27 03:34:36, Benedikt Meurer wrote:
> Nit: Use DCHECK_EQ(TypeCheckKind::kNumberOrOddball, use_info.type_check());

Done.

https://codereview.chromium.org/2184513003/diff/1/src/compiler/simplified-low...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2184513003/diff/1/src/compiler/simplified-low...
src/compiler/simplified-lowering.cc:1670: hint ==
BinaryOperationHints::kSigned32 ||
On 2016/07/27 05:34:01, Jarin wrote:
> On 2016/07/27 03:34:36, Benedikt Meurer wrote:
> > This if is redundant. Drop it completely, or phrase it as DCHECK.
> 
> +1 for the DCHECK.

As per offline discussion, I'll just remove this.

[epertoso, 2016-07-27 08:29:20]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-07-27 08:29:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2184513003/#ps20001
(title: "Update.")

[commit-bot: I haz the power, 2016-07-27 08:29:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 08:58:50]

Description was changed from

==========
[turbofan] Adds handling of number or oddball type feedback to
SpeculativeNumberShiftLeft.

This required the introduction of the CheckedNumberOrOddballAsWord32 use info,
and a change in the RepresentationChanger to handle it.

BUG=
==========

to

==========
[turbofan] Adds handling of number or oddball type feedback to
SpeculativeNumberShiftLeft.

This required the introduction of the CheckedNumberOrOddballAsWord32 use info,
and a change in the RepresentationChanger to handle it.

BUG=
==========

[commit-bot: I haz the power, 2016-07-27 08:58:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 09:04:28]

Description was changed from

==========
[turbofan] Adds handling of number or oddball type feedback to
SpeculativeNumberShiftLeft.

This required the introduction of the CheckedNumberOrOddballAsWord32 use info,
and a change in the RepresentationChanger to handle it.

BUG=
==========

to

==========
[turbofan] Adds handling of number or oddball type feedback to
SpeculativeNumberShiftLeft.

This required the introduction of the CheckedNumberOrOddballAsWord32 use info,
and a change in the RepresentationChanger to handle it.

BUG=

Committed: https://crrev.com/94ab292fba494f6968d18305f77d279d81af5d22
Cr-Commit-Position: refs/heads/master@{#38086}
==========

[commit-bot: I haz the power, 2016-07-27 09:04:29]

Patchset 2 (id:??) landed as
https://crrev.com/94ab292fba494f6968d18305f77d279d81af5d22
Cr-Commit-Position: refs/heads/master@{#38086}