[turbofan] Adds handling of number or oddball type feedback to SpeculativeNumberShiftLeft.

src/compiler/simplified-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/simplified-lowering.h"
 
 #include <limits>
 
 #include "src/address-map.h"
 #include "src/base/bits.h"
@@ skipping 1649 matching lines @@
           VisitBinop(node, UseInfo::TruncatingWord32(),
                      UseInfo::TruncatingWord32(),
                      MachineRepresentation::kWord32);
           if (lower()) {
             lowering->DoShift(node, lowering->machine()->Word32Shl(), rhs_type);
           }
           return;
         }
         BinaryOperationHints::Hint hint = BinaryOperationHintOf(node->op());
         if (hint == BinaryOperationHints::kSignedSmall ||
-            hint == BinaryOperationHints::kSigned32) {
+            hint == BinaryOperationHints::kSigned32 ||

[Benedikt Meurer, 2016/07/27 03:34:36]

This if is redundant. Drop it completely, or phrase it as DCHECK.

[Jarin, 2016/07/27 05:34:01]

+1 for the DCHECK.

[epertoso, 2016/07/27 08:26:36]

As per offline discussion, I'll just remove this.

+            hint == BinaryOperationHints::kNumberOrOddball) {
           Type* rhs_type = GetUpperBound(node->InputAt(1));
-          if (truncation.IsUsedAsWord32()) {
-            VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
-                       MachineRepresentation::kWord32);
-            if (lower()) {
-              lowering->DoShift(node, lowering->machine()->Word32Shl(),
-                                rhs_type);
-            }
-          } else {
-            VisitBinop(node, UseInfo::CheckedSigned32AsWord32(),
-                       MachineRepresentation::kWord32, Type::Signed32());
-            if (lower()) {
-              lowering->DoShift(node, lowering->machine()->Word32Shl(),
-                                rhs_type);
-            }
+          VisitBinop(node, hint == BinaryOperationHints::kNumberOrOddball
+                               ? UseInfo::CheckedNumberOrOddballAsWord32()
+                               : UseInfo::CheckedSigned32AsWord32(),
+                     MachineRepresentation::kWord32, Type::Signed32());
+          if (lower()) {
+            lowering->DoShift(node, lowering->machine()->Word32Shl(), rhs_type);
           }
           return;
         }
         UNREACHABLE();
       }
       case IrOpcode::kNumberShiftRight: {
         Type* rhs_type = GetUpperBound(node->InputAt(1));
         VisitBinop(node, UseInfo::TruncatingWord32(),
                    UseInfo::TruncatingWord32(), MachineRepresentation::kWord32);
         if (lower()) {
@@ skipping 1808 matching lines @@
         isolate(), graph()->zone(), callable.descriptor(), 0, flags,
         Operator::kNoProperties);
     to_number_operator_.set(common()->Call(desc));
   }
   return to_number_operator_.get();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8