Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: base/sequence_token_unittest.cc

Issue 2184353003: Explicitly call SequenceToken's default constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sequence_token_unittest.cc
diff --git a/base/sequence_token_unittest.cc b/base/sequence_token_unittest.cc
index 9cbf6747be8e114628c631b686fda7b5e453ab3e..2bdc02644178465c448df09bc3bd0cea20a4b0e0 100644
--- a/base/sequence_token_unittest.cc
+++ b/base/sequence_token_unittest.cc
@@ -14,8 +14,8 @@ TEST(SequenceTokenTest, IsValid) {
}
TEST(SequenceTokenTest, OperatorEquals) {
- const SequenceToken invalid_a;
- const SequenceToken invalid_b;
+ const SequenceToken invalid_a{};
danakj 2016/07/28 21:08:42 Current style guidance is to not use {} to call a
jif 2016/07/28 22:06:11 Done.
+ const SequenceToken invalid_b{};
const SequenceToken valid_a = SequenceToken::Create();
const SequenceToken valid_b = SequenceToken::Create();
@@ -31,8 +31,8 @@ TEST(SequenceTokenTest, OperatorEquals) {
}
TEST(SequenceTokenTest, OperatorNotEquals) {
- const SequenceToken invalid_a;
- const SequenceToken invalid_b;
+ const SequenceToken invalid_a{};
+ const SequenceToken invalid_b{};
const SequenceToken valid_a = SequenceToken::Create();
const SequenceToken valid_b = SequenceToken::Create();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698