Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2184353003:
Explicitly call SequenceToken's default constructor. (Closed)
DescriptionExplicitly call SequenceToken's default constructor.
This CL is to workaround a clang bug occurring when building
sequence_token_unittest.cc for Chrome iOS.
BUG=632330
Committed: https://crrev.com/0240044e435a3708d3f082771943a498a4cf3592
Cr-Commit-Position: refs/heads/master@{#408515}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressed comment. #Messages
Total messages: 19 (11 generated)
Description was changed from ========== Explicitely call default constructor. BUG=632330 ========== to ========== Explicitly call default constructor. This CL is to workaround a clang bug occurring when building sequence_token_unittest.cc for Chrome iOS. BUG=632330 ==========
Description was changed from ========== Explicitly call default constructor. This CL is to workaround a clang bug occurring when building sequence_token_unittest.cc for Chrome iOS. BUG=632330 ========== to ========== Explicitly call default constructor. This CL is to workaround a clang bug occurring when building sequence_token_unittest.cc for Chrome iOS. BUG=632330 ==========
Description was changed from ========== Explicitly call default constructor. This CL is to workaround a clang bug occurring when building sequence_token_unittest.cc for Chrome iOS. BUG=632330 ========== to ========== Explicitly call SequenceToken's default constructor. This CL is to workaround a clang bug occurring when building sequence_token_unittest.cc for Chrome iOS. BUG=632330 ==========
jif@chromium.org changed reviewers: + danakj@chromium.org
ptal
https://codereview.chromium.org/2184353003/diff/1/base/sequence_token_unittes... File base/sequence_token_unittest.cc (right): https://codereview.chromium.org/2184353003/diff/1/base/sequence_token_unittes... base/sequence_token_unittest.cc:17: const SequenceToken invalid_a{}; Current style guidance is to not use {} to call a constructor like this. Can you either write this as "= SequenceToken()" or just drop the const?
ptal https://codereview.chromium.org/2184353003/diff/1/base/sequence_token_unittes... File base/sequence_token_unittest.cc (right): https://codereview.chromium.org/2184353003/diff/1/base/sequence_token_unittes... base/sequence_token_unittest.cc:17: const SequenceToken invalid_a{}; On 2016/07/28 21:08:42, danakj wrote: > Current style guidance is to not use {} to call a constructor like this. Can you > either write this as "= SequenceToken()" or just drop the const? Done.
The CQ bit was checked by jif@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Explicitly call SequenceToken's default constructor. This CL is to workaround a clang bug occurring when building sequence_token_unittest.cc for Chrome iOS. BUG=632330 ========== to ========== Explicitly call SequenceToken's default constructor. This CL is to workaround a clang bug occurring when building sequence_token_unittest.cc for Chrome iOS. BUG=632330 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Explicitly call SequenceToken's default constructor. This CL is to workaround a clang bug occurring when building sequence_token_unittest.cc for Chrome iOS. BUG=632330 ========== to ========== Explicitly call SequenceToken's default constructor. This CL is to workaround a clang bug occurring when building sequence_token_unittest.cc for Chrome iOS. BUG=632330 Committed: https://crrev.com/0240044e435a3708d3f082771943a498a4cf3592 Cr-Commit-Position: refs/heads/master@{#408515} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0240044e435a3708d3f082771943a498a4cf3592 Cr-Commit-Position: refs/heads/master@{#408515}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2710823004/ by jif@chromium.org. The reason for reverting is: xcode's clang now supports const default initialization.. |
