Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: lib/src/barback/dependency_computer.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/barback/dart2js_transformer.dart ('k') | lib/src/barback/foreign_transformer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/barback/dependency_computer.dart
diff --git a/lib/src/barback/dependency_computer.dart b/lib/src/barback/dependency_computer.dart
index 1166184b5ed9203e45df9cc23a5285db7cfea532..fedc2080a830468d9cd27a3e6637e117212d113c 100644
--- a/lib/src/barback/dependency_computer.dart
+++ b/lib/src/barback/dependency_computer.dart
@@ -69,7 +69,7 @@ class DependencyComputer {
/// `T1` to `T2`.
Map<TransformerId, Set<TransformerId>> transformersNeededByTransformers(
[Iterable<TransformerId> transformers]) {
- var result = {};
+ var result = <TransformerId, Set<TransformerId>>{};
if (transformers == null) {
transformers = ordered(_graph.packages.keys).expand((packageName) {
@@ -162,8 +162,8 @@ class DependencyComputer {
return _transformersNeededByPackages[rootPackage];
}
- var results = new Set();
- var seen = new Set();
+ var results = new Set<TransformerId>();
+ var seen = new Set<String>();
traversePackage(packageName) {
if (seen.contains(packageName)) return;
@@ -389,10 +389,10 @@ class _PackageDependencyComputer {
return _transitiveExternalDirectives[rootLibrary];
}
- var results = new Set();
- var seen = new Set();
+ var results = new Set<Uri>();
+ var seen = new Set<String>();
- traverseLibrary(library) {
+ traverseLibrary(String library) {
library = p.normalize(library);
if (seen.contains(library)) return true;
seen.add(library);
« no previous file with comments | « lib/src/barback/dart2js_transformer.dart ('k') | lib/src/barback/foreign_transformer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698