Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: lib/src/barback/dart2js_transformer.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/barback/cycle_exception.dart ('k') | lib/src/barback/dependency_computer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/barback/dart2js_transformer.dart
diff --git a/lib/src/barback/dart2js_transformer.dart b/lib/src/barback/dart2js_transformer.dart
index 431c5904e4360652e19f4875787e4bff4db8a9b4..94d05d18fc49b70e62b6d9c4c3f233239a506528 100644
--- a/lib/src/barback/dart2js_transformer.dart
+++ b/lib/src/barback/dart2js_transformer.dart
@@ -7,6 +7,7 @@ import 'dart:convert';
import 'package:analyzer/analyzer.dart';
import 'package:barback/barback.dart';
+import 'package:collection/collection.dart';
import 'package:path/path.dart' as p;
import 'package:pool/pool.dart';
@@ -154,7 +155,7 @@ class Dart2JSTransformer extends Transformer implements LazyTransformer {
var options = _settings.configuration['commandLineOptions'];
if (options is List && options.every((option) => option is String)) {
- return options;
+ return DelegatingList.typed(options);
}
throw new FormatException('Invalid value for '
@@ -172,7 +173,9 @@ class Dart2JSTransformer extends Transformer implements LazyTransformer {
if (environment is Map &&
environment.keys.every((key) => key is String) &&
environment.values.every((key) => key is String)) {
- return mergeMaps(environment, _environment.environmentConstants);
+ return mergeMaps(
+ DelegatingMap.typed(environment),
+ _environment.environmentConstants);
}
throw new FormatException('Invalid value for \$dart2js.environment: '
« no previous file with comments | « lib/src/barback/cycle_exception.dart ('k') | lib/src/barback/dependency_computer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698