Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2184163003: Enable backend switching for Windows Viewer (Closed)

Created:
4 years, 4 months ago by jvanverth1
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable backend switching for Windows Viewer BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184163003 Committed: https://skia.googlesource.com/skia/+/b8794ccea2163c780760b6e0f7ebd022f2c85d33

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete extra glMakeCurrent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -32 lines) Patch
M tools/viewer/Viewer.cpp View 2 chunks +29 lines, -11 lines 0 comments Download
M tools/viewer/sk_app/Window.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/win/GLWindowContext_win.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/viewer/sk_app/win/Window_win.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/win/Window_win.cpp View 2 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jvanverth1
4 years, 4 months ago (2016-07-27 20:10:46 UTC) #3
bsalomon
lgtm w/ question about whether we need to get the dc. https://codereview.chromium.org/2184163003/diff/1/tools/viewer/sk_app/win/GLWindowContext_win.cpp File tools/viewer/sk_app/win/GLWindowContext_win.cpp (right): ...
4 years, 4 months ago (2016-07-27 20:26:38 UTC) #4
jvanverth1
https://codereview.chromium.org/2184163003/diff/1/tools/viewer/sk_app/win/GLWindowContext_win.cpp File tools/viewer/sk_app/win/GLWindowContext_win.cpp (right): https://codereview.chromium.org/2184163003/diff/1/tools/viewer/sk_app/win/GLWindowContext_win.cpp#newcode99 tools/viewer/sk_app/win/GLWindowContext_win.cpp:99: HDC dc = GetDC(fHWND); Deleted. I added this in ...
4 years, 4 months ago (2016-07-27 20:41:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184163003/20001
4 years, 4 months ago (2016-07-27 20:42:23 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 21:29:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b8794ccea2163c780760b6e0f7ebd022f2c85d33

Powered by Google App Engine
This is Rietveld 408576698