GN: fixes for Mac

GN: fixes for Mac

 - Make fiddle build on Mac (skipping GL).
 - Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
 - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002


NOTREECHECKS=true
This doesn't affect Chrome/Blink, so landing through the closed tree.

Committed: https://skia.googlesource.com/skia/+/7d10b9f6e61ce8cb5387291580c1c0645f72b167

[mtklein_C, 2016-07-27 12:50:48]

Description was changed from

==========
GN: fixes for Mac

 - Make fiddle build on Mac (without GL).
 - Depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
 - Re-arrange third_party a bit to be more similar to Chrome's.

BUG=skia:
==========

to

==========
GN: fixes for Mac

 - Make fiddle build on Mac (without GL).
 - Depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
 - Re-arrange third_party a bit to be more similar to Chrome's.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002
==========

[mtklein_C, 2016-07-27 12:54:14]

Description was changed from

==========
GN: fixes for Mac

 - Make fiddle build on Mac (without GL).
 - Depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
 - Re-arrange third_party a bit to be more similar to Chrome's.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002
==========

to

==========
GN: fixes for Mac

 - Make fiddle build on Mac (without GL).
 - Depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
 - Re-arrange third_party a bit to be more Fuchsia/Chrome compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002
==========

[mtklein_C, 2016-07-27 12:54:45]

Description was changed from

==========
GN: fixes for Mac

 - Make fiddle build on Mac (without GL).
 - Depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
 - Re-arrange third_party a bit to be more Fuchsia/Chrome compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002
==========

to

==========
GN: fixes for Mac

 - Make fiddle build on Mac (without GL).
 - Depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
 - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome
compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002
==========

[mtklein_C, 2016-07-27 12:56:18]

Description was changed from

==========
GN: fixes for Mac

 - Make fiddle build on Mac (without GL).
 - Depend on libpng and libjpeg-turbo unconditionally, not just on Linux.
 - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome
compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002
==========

to

==========
GN: fixes for Mac

 - Make fiddle build on Mac (skipping GL).
 - Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo
unconditionally, not just on Linux.
 - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome
compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002
==========

[mtklein_C, 2016-07-27 13:01:27]

mtklein@chromium.org changed reviewers:
+ abarth@chromium.org, jcgregorio@google.com

[mtklein_C, 2016-07-27 13:01:28]

Today is definitely the day to stand up some bots... how much you want to be
this somehow breaks GN on Linux?


@abarth, this is mostly FYI.  We're busily trying to make our GN build real, but
we don't have a way to test that we don't break you yet.  (We don't have a way
to test we don't break ourselves yet.)  The main thing of interest here for you
is that I'm trying to make our //third_party targets compatible with Chromium's
like we did for zlib.  Does this make sense?

[mtklein_C, 2016-07-27 13:01:45]

On 2016/07/27 at 13:01:28, mtklein_C wrote:
> Today is definitely the day to stand up some bots... how much you want to be
this somehow breaks GN on Linux?
*bet

[mtklein_C, 2016-07-27 16:23:23]

On 2016/07/27 at 13:01:45, mtklein_C wrote:
> On 2016/07/27 at 13:01:28, mtklein_C wrote:
> > Today is definitely the day to stand up some bots... how much you want to be
this somehow breaks GN on Linux?
> *bet

I did break Ganesh support inside fiddle_main, but it's fixed now at PS2

[abarth, 2016-07-27 16:59:00]

abarth@google.com changed reviewers:
+ abarth@google.com

[abarth, 2016-07-27 16:59:00]

https://codereview.chromium.org/2184133002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2184133002/diff/20001/BUILD.gn#newcode152
BUILD.gn:152: "//third_party/libpng",
We don't have these libs yet, but when we do have them, hits will work properly.
 Please don't feel blocked on us.  We've got Skia pinning to a rev and we'll
backfill these sorts of things when we bump up the revision we use.

[mtklein, 2016-07-27 17:04:06]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-07-27 17:04:07]

https://codereview.chromium.org/2184133002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2184133002/diff/20001/BUILD.gn#newcode152
BUILD.gn:152: "//third_party/libpng",
On 2016/07/27 16:59:00, abarth wrote:
> We don't have these libs yet, but when we do have them, hits will work
properly.
>  Please don't feel blocked on us.  We've got Skia pinning to a rev and we'll
> backfill these sorts of things when we bump up the revision we use.

Thanks, sounds good.

(The versions you see in our GN files are pretty bare-bones... none of the
platform specific code.  Should be safe to steal, but not optimal.)

[jcgregorio, 2016-07-27 17:18:57]

lgtm

[mtklein, 2016-07-27 17:20:13]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-07-27 17:20:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-07-27 17:20:43]

Description was changed from

==========
GN: fixes for Mac

 - Make fiddle build on Mac (skipping GL).
 - Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo
unconditionally, not just on Linux.
 - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome
compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002
==========

to

==========
GN: fixes for Mac

 - Make fiddle build on Mac (skipping GL).
 - Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo
unconditionally, not just on Linux.
 - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome
compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002


NOTREECHECKS=true
This doesn't affect Chrome/Blink, so landing through the closed tree.
==========

[commit-bot: I haz the power, 2016-07-27 18:17:20]

Description was changed from

==========
GN: fixes for Mac

 - Make fiddle build on Mac (skipping GL).
 - Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo
unconditionally, not just on Linux.
 - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome
compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002


NOTREECHECKS=true
This doesn't affect Chrome/Blink, so landing through the closed tree.
==========

to

==========
GN: fixes for Mac

 - Make fiddle build on Mac (skipping GL).
 - Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo
unconditionally, not just on Linux.
 - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome
compatible.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002


NOTREECHECKS=true
This doesn't affect Chrome/Blink, so landing through the closed tree.

Committed:
https://skia.googlesource.com/skia/+/7d10b9f6e61ce8cb5387291580c1c0645f72b167
==========

[commit-bot: I haz the power, 2016-07-27 18:17:22]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7d10b9f6e61ce8cb5387291580c1c0645f72b167