Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: BUILD.gn

Issue 2184133002: GN: fixes for Mac (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: fix linux Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gn/echo_headers.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 1ddf12a9579855a38fdfe746e655ca0bb2958514..07c70097afcec761e09065957226ce99462a76d4 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -19,7 +19,7 @@ skia_public_includes = [
"include/utils",
"include/utils/mac",
- "include/c", # TODO: move back to top, order shouldn't matter
+ "include/c", # TODO: move back to top, order shouldn't matter
]
# Skia public API, generally provided by :skia.
@@ -148,6 +148,8 @@ component("skia") {
":opts_avx",
":opts_sse41",
":opts_ssse3",
+ "//third_party/libjpeg_turbo",
+ "//third_party/libpng",
abarth 2016/07/27 16:59:00 We don't have these libs yet, but when we do have
mtklein 2016/07/27 17:04:07 Thanks, sounds good. (The versions you see in our
"//third_party/zlib",
]
@@ -221,8 +223,6 @@ component("skia") {
deps += [
"third_party:fontconfig",
"third_party:freetype2",
- "third_party:libjpeg-turbo",
- "third_party:libpng",
]
sources += [
"src/fonts/SkFontMgr_fontconfig.cpp",
@@ -262,7 +262,10 @@ action("skia.h") {
executable("fiddle") {
include_dirs = [ "$target_gen_dir" ]
- libs = [ "OSMesa" ]
+ libs = []
+ if (is_linux) {
+ libs += [ "OSMesa" ]
+ }
sources = [
"tools/fiddle/draw.cpp",
« no previous file with comments | « no previous file | gn/echo_headers.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698