components/scheduler/renderer/web_view_scheduler_impl_unittest.cc - Issue 2184123002: Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING

Unified Diff: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Issue 2184123002: Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/renderer/renderer_scheduler_impl.cc ('K') | « components/scheduler/renderer/web_view_scheduler_impl.cc ('k') | third_party/WebKit/Source/platform/WebViewSchedulerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

diff --git a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

index 49bed4d1dd5cac814544cb7738b094ed6336ad51..5f4e4b5779ddf475188d1318d748b012bffd7555 100644

--- a/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

+++ b/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

@@ -34,9 +34,9 @@ class WebViewSchedulerImplTest : public testing::Test {

clock_->Advance(base::TimeDelta::FromMicroseconds(5000));

mock_task_runner_ =

make_scoped_refptr(new cc::OrderedSimpleTaskRunner(clock_.get(), true));

- delagate_ = SchedulerTqmDelegateForTest::Create(

+ delegate_ = SchedulerTqmDelegateForTest::Create(

mock_task_runner_, base::WrapUnique(new TestTimeSource(clock_.get())));

- scheduler_.reset(new RendererSchedulerImpl(delagate_));

+ scheduler_.reset(new RendererSchedulerImpl(delegate_));

web_view_scheduler_.reset(new WebViewSchedulerImpl(

nullptr, scheduler_.get(), DisableBackgroundTimerThrottling()));

web_frame_scheduler_ =

@@ -54,7 +54,7 @@ class WebViewSchedulerImplTest : public testing::Test {

std::unique_ptr<base::SimpleTestTickClock> clock_;

scoped_refptr<cc::OrderedSimpleTaskRunner> mock_task_runner_;

- scoped_refptr<SchedulerTqmDelegate> delagate_;

+ scoped_refptr<SchedulerTqmDelegate> delegate_;

std::unique_ptr<RendererSchedulerImpl> scheduler_;

std::unique_ptr<WebViewSchedulerImpl> web_view_scheduler_;

std::unique_ptr<WebFrameSchedulerImpl> web_frame_scheduler_;

@@ -506,7 +506,9 @@ TEST_F(WebViewSchedulerImplTest,

VirtualTimePolicy_PAUSE_IF_NETWORK_FETCHES_PENDING) {

web_view_scheduler_->setVirtualTimePolicy(

VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING);

- EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());

+ // Initially virtual time is not allowed to advance until we have seen at

Sami 2016/07/28 10:46:34 This comment could be useful in the virtual time A

alex clarke (OOO till 29th) 2016/07/29 13:35:01 Done.

+ // least one load.

+ EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());

web_view_scheduler_->DidStartLoading(1u);

EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());

@@ -525,6 +527,12 @@ TEST_F(WebViewSchedulerImplTest,

web_view_scheduler_->DidStopLoading(3u);

EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());

+ web_view_scheduler_->DidStartLoading(4u);

+ EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());

+ web_view_scheduler_->DidStopLoading(4u);

+ EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());

}

TEST_F(WebViewSchedulerImplTest, RedundantDidStopLoadingCallsAreHarmless) {