Change VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING

components/scheduler/renderer/web_view_scheduler_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/scheduler/renderer/web_view_scheduler_impl.h"
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/memory/ptr_util.h"
@@ skipping 16 matching lines @@
 class WebViewSchedulerImplTest : public testing::Test {
  public:
   WebViewSchedulerImplTest() {}
   ~WebViewSchedulerImplTest() override {}
 
   void SetUp() override {
     clock_.reset(new base::SimpleTestTickClock());
     clock_->Advance(base::TimeDelta::FromMicroseconds(5000));
     mock_task_runner_ =
         make_scoped_refptr(new cc::OrderedSimpleTaskRunner(clock_.get(), true));
-    delagate_ = SchedulerTqmDelegateForTest::Create(
+    delegate_ = SchedulerTqmDelegateForTest::Create(
         mock_task_runner_, base::WrapUnique(new TestTimeSource(clock_.get())));
-    scheduler_.reset(new RendererSchedulerImpl(delagate_));
+    scheduler_.reset(new RendererSchedulerImpl(delegate_));
     web_view_scheduler_.reset(new WebViewSchedulerImpl(
         nullptr, scheduler_.get(), DisableBackgroundTimerThrottling()));
     web_frame_scheduler_ =
         web_view_scheduler_->createWebFrameSchedulerImpl(nullptr);
   }
 
   void TearDown() override {
     web_frame_scheduler_.reset();
     web_view_scheduler_.reset();
     scheduler_->Shutdown();
     scheduler_.reset();
   }
 
   virtual bool DisableBackgroundTimerThrottling() const { return false; }
 
   std::unique_ptr<base::SimpleTestTickClock> clock_;
   scoped_refptr<cc::OrderedSimpleTaskRunner> mock_task_runner_;
-  scoped_refptr<SchedulerTqmDelegate> delagate_;
+  scoped_refptr<SchedulerTqmDelegate> delegate_;
   std::unique_ptr<RendererSchedulerImpl> scheduler_;
   std::unique_ptr<WebViewSchedulerImpl> web_view_scheduler_;
   std::unique_ptr<WebFrameSchedulerImpl> web_frame_scheduler_;
 };
 
 TEST_F(WebViewSchedulerImplTest, TestDestructionOfFrameSchedulersBefore) {
   std::unique_ptr<blink::WebFrameScheduler> frame1(
       web_view_scheduler_->createFrameScheduler(nullptr));
   std::unique_ptr<blink::WebFrameScheduler> frame2(
       web_view_scheduler_->createFrameScheduler(nullptr));
@@ skipping 431 matching lines @@
                                      9990.0);
 
   mock_task_runner_->RunForPeriod(base::TimeDelta::FromSeconds(100));
   EXPECT_EQ(10, run_count);
 }
 
 TEST_F(WebViewSchedulerImplTest,
        VirtualTimePolicy_PAUSE_IF_NETWORK_FETCHES_PENDING) {
   web_view_scheduler_->setVirtualTimePolicy(
       VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING);
-  EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+  // Initially virtual time is not allowed to advance until we have seen at

[Sami, 2016/07/28 10:46:34]

This comment could be useful in the virtual time API header too.

[alex clarke (OOO till 29th), 2016/07/29 13:35:01]

Done.

+  // least one load.
+  EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStartLoading(1u);
   EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStartLoading(2u);
   EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStopLoading(2u);
   EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStartLoading(3u);
   EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStopLoading(1u);
   EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStopLoading(3u);
   EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+  web_view_scheduler_->DidStartLoading(4u);
+  EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
+
+  web_view_scheduler_->DidStopLoading(4u);
+  EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 }
 
 TEST_F(WebViewSchedulerImplTest, RedundantDidStopLoadingCallsAreHarmless) {
   web_view_scheduler_->setVirtualTimePolicy(
       VirtualTimePolicy::PAUSE_IF_NETWORK_FETCHES_PENDING);
 
   web_view_scheduler_->DidStartLoading(1u);
   EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStopLoading(1u);
   EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStopLoading(1u);
   EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStopLoading(1u);
   EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStartLoading(2u);
   EXPECT_FALSE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 
   web_view_scheduler_->DidStopLoading(2u);
   EXPECT_TRUE(web_view_scheduler_->virtualTimeAllowedToAdvance());
 }
 
 }  // namespace scheduler