Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 2061763002: third_party: Update to version 5 of remote_shell_protocol. (Closed)

Created:
4 years, 6 months ago by reveman
Modified:
4 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, oshima, varkha, yoshiki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party: Update to version 5 of remote_shell_protocol. Adds support for set_title and set_top_inset requests. BUG=621166 TBR=piman@chromium.org Committed: https://crrev.com/58e328a2ca8e8b8b6f6a0317872c7684fbce784c Cr-Commit-Position: refs/heads/master@{#401356}

Patch Set 1 #

Patch Set 2 : rebase and add set_top_inset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -31 lines) Patch
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 1 4 chunks +44 lines, -2 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 1 1 chunk +45 lines, -17 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 1 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 1 3 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061763002/1
4 years, 6 months ago (2016-06-13 15:25:31 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 15:57:54 UTC) #4
reveman
fyi, this also fixes some version issues that I missed in my review of version ...
4 years, 6 months ago (2016-06-22 17:28:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061763002/20001
4 years, 6 months ago (2016-06-22 17:28:37 UTC) #9
piman
lgtm
4 years, 6 months ago (2016-06-22 18:00:49 UTC) #10
piman
lgtm lgtm
4 years, 6 months ago (2016-06-22 18:00:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 18:25:07 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:29:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58e328a2ca8e8b8b6f6a0317872c7684fbce784c
Cr-Commit-Position: refs/heads/master@{#401356}

Powered by Google App Engine
This is Rietveld 408576698