Always fallback to checking bitmaps during under-invalidation checking

Always fallback to checking bitmaps during under-invalidation checking

There were some false positives of under-invalidation because the client
produces slightly different pictures for the same visual result.

Always fallback to checking bitmaps to avoid such false-positives.

This won't degrade performance because normally the pictures should
equal.

Also changed bitmap comparison to a more stable version and make the
result more readable.

BUG=619603
Committed: https://crrev.com/e704a3c066cf58982cb44835de78628ded169db0
Cr-Commit-Position: refs/heads/master@{#408543}

[Xianzhu, 2016-07-27 20:03:14]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 20:03:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-07-27 20:54:58]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 20:55:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 22:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 22:21:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-07-28 20:29:07]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 20:29:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 23:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 23:16:06]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-07-28 23:21:55]

Description was changed from

==========
Always fallback to checking bitmaps during under-invalidation checking

There were some false positives of under-invalidation because the client
produces slightly different pictures for the same visual result.

Always fallback to checking bitmaps to avoid such false-positives.

This won't degrade performance because normally the pictures should
equal.

BUG=619603
==========

to

==========
Always fallback to checking bitmaps during under-invalidation checking

There were some false positives of under-invalidation because the client
produces slightly different pictures for the same visual result.

Always fallback to checking bitmaps to avoid such false-positives.

This won't degrade performance because normally the pictures should
equal.

Also changed bitmap comparison to a more stable version and make the
result more readable.

BUG=619603
==========

[Xianzhu, 2016-07-28 23:22:08]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2016-07-28 23:26:45]

On 2016/07/28 at 23:22:09, wangxianzhu wrote:
> 

LGTM

Do you know why this didn't come up before?

[Xianzhu, 2016-07-28 23:37:11]

On 2016/07/28 23:26:45, pdr. wrote:
> On 2016/07/28 at 23:22:09, wangxianzhu wrote:
> > 
> 
> LGTM
> 
> Do you know why this didn't come up before?

Before https://codereview.chromium.org/2049263003 we didn't run
under-invalidation checking on waterfall bots so we didn't discover them in
time.

[Xianzhu, 2016-07-28 23:37:48]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-07-28 23:38:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-07-28 23:39:30]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2016-07-28 23:43:12]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-07-28 23:43:13]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2184053003/#ps60001
(title: "-")

[commit-bot: I haz the power, 2016-07-28 23:43:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 01:11:47]

Description was changed from

==========
Always fallback to checking bitmaps during under-invalidation checking

There were some false positives of under-invalidation because the client
produces slightly different pictures for the same visual result.

Always fallback to checking bitmaps to avoid such false-positives.

This won't degrade performance because normally the pictures should
equal.

Also changed bitmap comparison to a more stable version and make the
result more readable.

BUG=619603
==========

to

==========
Always fallback to checking bitmaps during under-invalidation checking

There were some false positives of under-invalidation because the client
produces slightly different pictures for the same visual result.

Always fallback to checking bitmaps to avoid such false-positives.

This won't degrade performance because normally the pictures should
equal.

Also changed bitmap comparison to a more stable version and make the
result more readable.

BUG=619603
==========

[commit-bot: I haz the power, 2016-07-29 01:11:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-29 01:14:43]

Description was changed from

==========
Always fallback to checking bitmaps during under-invalidation checking

There were some false positives of under-invalidation because the client
produces slightly different pictures for the same visual result.

Always fallback to checking bitmaps to avoid such false-positives.

This won't degrade performance because normally the pictures should
equal.

Also changed bitmap comparison to a more stable version and make the
result more readable.

BUG=619603
==========

to

==========
Always fallback to checking bitmaps during under-invalidation checking

There were some false positives of under-invalidation because the client
produces slightly different pictures for the same visual result.

Always fallback to checking bitmaps to avoid such false-positives.

This won't degrade performance because normally the pictures should
equal.

Also changed bitmap comparison to a more stable version and make the
result more readable.

BUG=619603

Committed: https://crrev.com/e704a3c066cf58982cb44835de78628ded169db0
Cr-Commit-Position: refs/heads/master@{#408543}
==========

[commit-bot: I haz the power, 2016-07-29 01:14:44]

Patchset 4 (id:??) landed as
https://crrev.com/e704a3c066cf58982cb44835de78628ded169db0
Cr-Commit-Position: refs/heads/master@{#408543}