Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp

Issue 2184053003: Always fallback to checking bitmaps during under-invalidation checking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp b/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
index eefcd8ff9b74785d7ae9271f43d57887187c934f..63cf3c81a50497f8aa548f99b433dd135fe745a5 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
@@ -17,9 +17,8 @@ DrawingRecorder::DrawingRecorder(GraphicsContext& context, const DisplayItemClie
, m_displayItemClient(displayItemClient)
, m_displayItemType(displayItemType)
, m_knownToBeOpaque(false)
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
, m_displayItemPosition(m_context.getPaintController().newDisplayItemList().size())
- , m_underInvalidationCheckingMode(DrawingDisplayItem::CheckPicture)
#endif
{
if (context.getPaintController().displayItemConstructionIsDisabled())
@@ -29,9 +28,9 @@ DrawingRecorder::DrawingRecorder(GraphicsContext& context, const DisplayItemClie
DCHECK(RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled()
|| !useCachedDrawingIfPossible(m_context, m_displayItemClient, m_displayItemType));
- ASSERT(DisplayItem::isDrawingType(displayItemType));
+ DCHECK(DisplayItem::isDrawingType(displayItemType));
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
context.setInDrawingRecorder(true);
#endif
@@ -40,7 +39,7 @@ DrawingRecorder::DrawingRecorder(GraphicsContext& context, const DisplayItemClie
IntRect cullRect = enclosingIntRect(floatCullRect);
context.beginRecording(cullRect);
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
if (RuntimeEnabledFeatures::slimmingPaintStrictCullRectClippingEnabled()) {
// Skia depends on the cull rect containing all of the display item commands. When strict
// cull rect clipping is enabled, make this explicit. This allows us to identify potential
@@ -61,22 +60,15 @@ DrawingRecorder::~DrawingRecorder()
if (m_context.getPaintController().displayItemConstructionIsDisabled())
return;
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
if (RuntimeEnabledFeatures::slimmingPaintStrictCullRectClippingEnabled())
m_context.restore();
m_context.setInDrawingRecorder(false);
- ASSERT(m_displayItemPosition == m_context.getPaintController().newDisplayItemList().size());
+ DCHECK(m_displayItemPosition == m_context.getPaintController().newDisplayItemList().size());
#endif
- m_context.getPaintController().createAndAppend<DrawingDisplayItem>(m_displayItemClient
- , m_displayItemType
- , m_context.endRecording()
- , m_knownToBeOpaque
-#if ENABLE(ASSERT)
- , m_underInvalidationCheckingMode
-#endif
- );
+ m_context.getPaintController().createAndAppend<DrawingDisplayItem>(m_displayItemClient, m_displayItemType, m_context.endRecording(), m_knownToBeOpaque);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698