Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: content/browser/renderer_host/delegated_frame_host.h

Issue 2184033003: Refactor browser process coordinate transformation methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/delegated_frame_host.h
diff --git a/content/browser/renderer_host/delegated_frame_host.h b/content/browser/renderer_host/delegated_frame_host.h
index f0d6b2423ed5f86d4fb56156219d6b7748c8c45c..2d3dba78edd63d27a2d71311e1dbad5f46d758db 100644
--- a/content/browser/renderer_host/delegated_frame_host.h
+++ b/content/browser/renderer_host/delegated_frame_host.h
@@ -168,9 +168,17 @@ class CONTENT_EXPORT DelegatedFrameHost
// Surface, find the relative transform between the Surfaces and apply it
// to a point. If a Surface has not yet been created this returns the
// same point with no transform applied.
- void TransformPointToLocalCoordSpace(const gfx::Point& point,
- const cc::SurfaceId& original_surface,
- gfx::Point* transformed_point);
+ gfx::Point TransformPointToLocalCoordSpace(
+ const gfx::Point& point,
+ const cc::SurfaceId& original_surface);
+
+ // Give a RenderWidgetHostViewBase that renders to a Surface that is
nasko 2016/07/27 22:52:13 nit: Given?
kenrb 2016/07/28 16:24:38 Done.
+ // contained within this class' Surface, find the relative transform between
+ // the Surfaces and apply it to a pont. If a Surfaec has not yet been
nasko 2016/07/27 22:52:13 nit: "a point"? "Surface"
kenrb 2016/07/28 16:24:37 Done.
+ // created this returns the same point with no transform applied.
+ gfx::Point TransformPointToCoordSpaceForView(
+ const gfx::Point& point,
+ RenderWidgetHostViewBase* target_view);
// Exposed for tests.
cc::SurfaceId SurfaceIdForTesting() const { return surface_id_; }

Powered by Google App Engine
This is Rietveld 408576698