DBC: Add missing deopt info after stack overflow checks.

DBC: Add missing deopt info after stack overflow checks.

Fixes collecting a debugger stack trace at an interrupt.

Enable most vm-service tests.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/634a62c9df04314edd8b4e526fa3cde73aaf8d93

[rmacnak, 2016-07-27 17:12:40]

rmacnak@google.com changed reviewers:
+ zra@google.com

[zra, 2016-07-27 17:22:06]

https://codereview.chromium.org/2183993004/diff/40001/runtime/observatory/tes...
File runtime/observatory/tests/service/test_helper.dart (right):

https://codereview.chromium.org/2183993004/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/test_helper.dart:333: var pid =
process.process.pid;
Is this leftover debugging stuff?

https://codereview.chromium.org/2183993004/diff/40001/runtime/vm/intermediate...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2183993004/diff/40001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:279: compiler->RecordSafepoint(locs());
See if you can do FlowGraphCompiler::RecordAfterCall(this)

[rmacnak, 2016-07-27 17:47:57]

https://codereview.chromium.org/2183993004/diff/40001/runtime/observatory/tes...
File runtime/observatory/tests/service/test_helper.dart (right):

https://codereview.chromium.org/2183993004/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/test_helper.dart:333: var pid =
process.process.pid;
On 2016/07/27 17:22:05, zra wrote:
> Is this leftover debugging stuff?

It's only for debugging and doesn't run as part of the test suite.

https://codereview.chromium.org/2183993004/diff/40001/runtime/vm/intermediate...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2183993004/diff/40001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:279: compiler->RecordSafepoint(locs());
On 2016/07/27 17:22:06, zra wrote:
> See if you can do FlowGraphCompiler::RecordAfterCall(this)

Yes, much better.

[rmacnak, 2016-07-27 17:48:20]

Description was changed from

==========
DBC: Add missing deopt info after stack overflow checks.

Fixes collecting a debugger stack trace at an interrupt. Compare
GenerateRuntimeCall on the other architectures.

Enable most vm-service tests.
==========

to

==========
DBC: Add missing deopt info after stack overflow checks.

Fixes collecting a debugger stack trace at an interrupt.

Enable most vm-service tests.
==========

[zra, 2016-07-27 17:50:17]

lgtm

[rmacnak, 2016-07-27 19:25:59]

Description was changed from

==========
DBC: Add missing deopt info after stack overflow checks.

Fixes collecting a debugger stack trace at an interrupt.

Enable most vm-service tests.
==========

to

==========
DBC: Add missing deopt info after stack overflow checks.

Fixes collecting a debugger stack trace at an interrupt.

Enable most vm-service tests.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/634a62c9df04314edd8b4e526fa3cde73aaf8d93
==========

[rmacnak, 2016-07-27 19:26:00]

Committed patchset #4 (id:60001) manually as
634a62c9df04314edd8b4e526fa3cde73aaf8d93 (presubmit successful).