Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: runtime/vm/deopt_instructions.cc

Issue 2183993004: DBC: Add missing deopt info after stack overflow checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/intermediate_language_dbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/deopt_instructions.cc
diff --git a/runtime/vm/deopt_instructions.cc b/runtime/vm/deopt_instructions.cc
index ae38a71afe89b0c34f686a605fc835a1020a1467..e658740f4cae75447090f79a13e20eaf7061bb9c 100644
--- a/runtime/vm/deopt_instructions.cc
+++ b/runtime/vm/deopt_instructions.cc
@@ -7,6 +7,7 @@
#include "vm/assembler.h"
#include "vm/code_patcher.h"
#include "vm/compiler.h"
+#include "vm/disassembler.h"
#include "vm/intermediate_language.h"
#include "vm/locations.h"
#include "vm/parser.h"
@@ -52,6 +53,13 @@ DeoptContext::DeoptContext(const StackFrame* frame,
deoptimizing_code_(deoptimizing_code) {
const TypedData& deopt_info = TypedData::Handle(
code.GetDeoptInfoAtPc(frame->pc(), &deopt_reason_, &deopt_flags_));
+#if defined(DEBUG)
+ if (deopt_info.IsNull()) {
+ OS::PrintErr("Missing deopt info for pc %" Px "\n", frame->pc());
+ DisassembleToStdout formatter;
+ code.Disassemble(&formatter);
+ }
+#endif
ASSERT(!deopt_info.IsNull());
deopt_info_ = deopt_info.raw();
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/intermediate_language_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698