Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2183943002: Revert of [Tracing] V8 Tracing Controller (Closed)

Created:
4 years, 4 months ago by lpy
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Tracing] V8 Tracing Controller (patchset #11 id:200001 of https://codereview.chromium.org/2137013006/ ) Reason for revert: Revert this CL due to V8 Arm Builder failure and V8 Mips Builder failure. https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/2456 https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/2506 Original issue's description: > [Tracing] V8 Tracing Controller > > V8 has had a trace event macro interface for while, but without a tracing > controller a standalone V8 would be unable to collect traces. > > This CL introduces a complete Tracing Controller system for V8. > It is fully function except that it does not yet store trace event args. > > This CL has a few components, > The tracing controller itself, contributed by the author of this CL > The Trace config (including the parser), contributed by lpy@ > The Trace Object, Trace Writer, and Trace Buffer are all contributed by rksang@ > > BUG=v8:4561 > LOG=N > > Committed: https://crrev.com/3d598452679ce208ad9b2f48e0fb3fae352ce375 > Cr-Commit-Position: refs/heads/master@{#38073} TBR=jochen@chromium.org,mattloring@google.com,rskang@google.com,yangguo@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4561 Committed: https://crrev.com/13c3d06a31813286eabc2394c5b87de04b3d4fa7 Cr-Commit-Position: refs/heads/master@{#38074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1037 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M include/libplatform/libplatform.h View 2 chunks +0 lines, -9 lines 0 comments Download
D include/libplatform/v8-tracing.h View 1 chunk +0 lines, -232 lines 0 comments Download
M src/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M src/d8.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/d8.cc View 4 chunks +0 lines, -28 lines 0 comments Download
M src/libplatform/default-platform.h View 4 chunks +1 line, -7 lines 0 comments Download
M src/libplatform/default-platform.cc View 4 chunks +5 lines, -32 lines 0 comments Download
D src/libplatform/tracing/trace-buffer.h View 1 chunk +0 lines, -48 lines 0 comments Download
D src/libplatform/tracing/trace-buffer.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D src/libplatform/tracing/trace-config.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D src/libplatform/tracing/trace-object.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D src/libplatform/tracing/trace-writer.h View 1 chunk +0 lines, -30 lines 0 comments Download
D src/libplatform/tracing/trace-writer.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D src/libplatform/tracing/tracing-controller.cc View 1 chunk +0 lines, -177 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/libplatform/test-tracing.cc View 1 chunk +0 lines, -186 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
lpy
Created Revert of [Tracing] V8 Tracing Controller
4 years, 4 months ago (2016-07-26 22:39:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183943002/1
4 years, 4 months ago (2016-07-26 22:39:29 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-07-26 22:39:31 UTC) #5
ofrobots
On 2016/07/26 22:39:31, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 4 months ago (2016-07-26 22:41:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183943002/1
4 years, 4 months ago (2016-07-26 22:42:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 22:42:36 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 22:45:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13c3d06a31813286eabc2394c5b87de04b3d4fa7
Cr-Commit-Position: refs/heads/master@{#38074}

Powered by Google App Engine
This is Rietveld 408576698