Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: src/d8.cc

Issue 2183943002: Revert of [Tracing] V8 Tracing Controller (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/d8.h ('k') | src/libplatform/default-platform.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index ec741b13f466bc22a07ff25c827f415df8dbbe94..611b3b570b1a4448cf5feae7dd13174e3934e289 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -35,7 +35,6 @@
#include "src/ostreams.h"
#include "include/libplatform/libplatform.h"
-#include "include/libplatform/v8-tracing.h"
#ifndef V8_SHARED
#include "src/api.h"
#include "src/base/cpu.h"
@@ -1997,9 +1996,6 @@
return false;
}
argv[i] = NULL;
- } else if (strcmp(argv[i], "--enable-tracing") == 0) {
- options.trace_enabled = true;
- argv[i] = NULL;
}
}
@@ -2416,7 +2412,6 @@
int Shell::Main(int argc, char* argv[]) {
- std::ofstream trace_file;
#if (defined(_WIN32) || defined(_WIN64))
UINT new_flags =
SEM_FAILCRITICALERRORS | SEM_NOGPFAULTERRORBOX | SEM_NOOPENFILEERRORBOX;
@@ -2483,29 +2478,6 @@
Isolate::Scope scope(isolate);
Initialize(isolate);
PerIsolateData data(isolate);
-
- if (options.trace_enabled) {
- trace_file.open("v8_trace.json");
- platform::tracing::TracingController* tracing_controller =
- new platform::tracing::TracingController();
- platform::tracing::TraceBuffer* trace_buffer =
- platform::tracing::TraceBuffer::CreateTraceBufferRingBuffer(
- platform::tracing::TraceBuffer::kRingBufferChunks,
- platform::tracing::TraceWriter::CreateJSONTraceWriter(
- trace_file));
- platform::tracing::TraceConfig* trace_config;
- trace_config = new platform::tracing::TraceConfig();
- trace_config->AddIncludedCategory("v8");
- tracing_controller->Initialize(trace_buffer);
- tracing_controller->StartTracing(trace_config);
-#ifndef V8_SHARED
- if (!i::FLAG_verify_predictable) {
- platform::SetTracingController(g_platform, tracing_controller);
- }
-#else
- platform::SetTracingController(g_platform, tracing_controller);
-#endif
- }
#ifndef V8_SHARED
if (options.dump_heap_constants) {
« no previous file with comments | « src/d8.h ('k') | src/libplatform/default-platform.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698