Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2183863002: Use a copy of string in EG web_view_matchers (Closed)

Created:
4 years, 4 months ago by gambard
Modified:
4 years, 4 months ago
CC:
chromium-reviews, baxley
Base URL:
https://chromium.googlesource.com/chromium/src.git@alertCoordinator2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a copy of string in EG web_view_matchers This CL fixes webViewMatcher for EG tests by adding a copy of the argument string before passing it to the handler. As the handler is asynchronous, this prevents occasional loss of reference. BUG=none Committed: https://crrev.com/8cfdb1ec994b5e345358b8da982b7f73066111cd Cr-Commit-Position: refs/heads/master@{#407814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ios/web/public/test/earl_grey/web_view_matchers.mm View 3 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
gambard
4 years, 4 months ago (2016-07-26 10:31:52 UTC) #2
Eugene But (OOO till 7-30)
lgtm, thanks for fixing this!
4 years, 4 months ago (2016-07-26 15:19:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2183863002/1
4 years, 4 months ago (2016-07-26 15:20:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 15:56:00 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 15:57:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cfdb1ec994b5e345358b8da982b7f73066111cd
Cr-Commit-Position: refs/heads/master@{#407814}

Powered by Google App Engine
This is Rietveld 408576698