Creates coordinator for ActionSheet and TextInput

Creates coordinator for ActionSheet and TextInput

This CL creates subclasses of AlertCoordinator for moving the use of
ActionSheet to another class and enabling the use of text inputs in the alert.

BUG=629515
Committed: https://crrev.com/b315bdd5602fed434cbec60e99d489c4584a937b
Cr-Commit-Position: refs/heads/master@{#407437}

[gambard, 2016-07-20 13:21:17]

gambard@chromium.org changed reviewers:
+ lpromero@chromium.org, marq@chromium.org

[gambard, 2016-07-20 13:21:18]

PTAL.

I finally made subclasses, I could find an elegant way to handle the popover and
the input texts.

[lpromero, 2016-07-21 21:47:50]

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.h (right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.h:15:
message:(NSString*)message NS_UNAVAILABLE;
Move it below the designated initializer.

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm
(right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm:18:
message:(NSString*)message;
Why redeclaring? Isn't that an implementation detail from the parent class?

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm:40:
_view.reset(view);
Missing a retain.

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator_unittest.mm
(right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator_unittest.mm:22:
UIView* view = [[[UIView alloc] initWithFrame:[[UIScreen mainScreen] bounds]]
Optional nit: I'd use viewController.view.bounds instead.

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h (right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h:45: @interface
AlertCoordinator (subclassing)
s/subclassing/Subclassing

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File ios/chrome/browser/ui/alert_coordinator/input_alert_coordinator.m (right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/input_alert_coordinator.m:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
Delete this file.

[gambard, 2016-07-22 13:51:19]

Thanks, PTAL.

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.h (right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.h:15:
message:(NSString*)message NS_UNAVAILABLE;
On 2016/07/21 21:47:49, lpromero wrote:
> Move it below the designated initializer.

Done.

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm
(right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm:18:
message:(NSString*)message;
On 2016/07/21 21:47:50, lpromero wrote:
> Why redeclaring? Isn't that an implementation detail from the parent class?

Done.
It was a "reminder" that this function is an override of the super class, but
this is not how we do this apparently :)

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm:40:
_view.reset(view);
On 2016/07/21 21:47:49, lpromero wrote:
> Missing a retain.

Done.

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator_unittest.mm
(right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator_unittest.mm:22:
UIView* view = [[[UIView alloc] initWithFrame:[[UIScreen mainScreen] bounds]]
On 2016/07/21 21:47:50, lpromero wrote:
> Optional nit: I'd use viewController.view.bounds instead.

Done.

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h (right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h:45: @interface
AlertCoordinator (subclassing)
On 2016/07/21 21:47:50, lpromero wrote:
> s/subclassing/Subclassing

Done.

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
File ios/chrome/browser/ui/alert_coordinator/input_alert_coordinator.m (right):

https://codereview.chromium.org/2167683002/diff/60001/ios/chrome/browser/ui/a...
ios/chrome/browser/ui/alert_coordinator/input_alert_coordinator.m:1: //
Copyright 2016 The Chromium Authors. All rights reserved.
On 2016/07/21 21:47:50, lpromero wrote:
> Delete this file.

Done.

[lpromero, 2016-07-22 15:03:34]

lgtm

[gambard, 2016-07-25 06:50:43]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2016-07-25 06:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 06:50:52]

This CL has an open dependency (Issue 2119373002 Patch 240001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[gambard, 2016-07-25 06:50:59]

The CQ bit was unchecked by gambard@chromium.org

[gambard, 2016-07-25 07:38:04]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 07:38:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 07:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 07:49:01]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[gambard, 2016-07-25 09:09:25]

The CQ bit was checked by gambard@chromium.org

[gambard, 2016-07-25 09:09:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2167683002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-25 09:09:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 09:29:33]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-25 09:31:31]

Description was changed from

==========
Creates coordinator for ActionSheet and TextInput

This CL creates subclasses of AlertCoordinator for moving the use of
ActionSheet to another class and enabling the use of text inputs in the alert.


BUG=629515
==========

to

==========
Creates coordinator for ActionSheet and TextInput

This CL creates subclasses of AlertCoordinator for moving the use of
ActionSheet to another class and enabling the use of text inputs in the alert.

BUG=629515

Committed: https://crrev.com/b315bdd5602fed434cbec60e99d489c4584a937b
Cr-Commit-Position: refs/heads/master@{#407437}
==========

[commit-bot: I haz the power, 2016-07-25 09:31:32]

Patchset 6 (id:??) landed as
https://crrev.com/b315bdd5602fed434cbec60e99d489c4584a937b
Cr-Commit-Position: refs/heads/master@{#407437}