content/browser/background_sync/background_sync_manager.h - Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager.h

Issue 2183783002: Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_browsertest.cc ('k') | content/browser/background_sync/background_sync_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager.h

diff --git a/content/browser/background_sync/background_sync_manager.h b/content/browser/background_sync/background_sync_manager.h

index f31a83a72910d4bd4c9f404853117ae4a45d6fb5..52391a20f5b05b7063f4cbe804c4e747bdbe7e9e 100644

--- a/content/browser/background_sync/background_sync_manager.h

+++ b/content/browser/background_sync/background_sync_manager.h

@@ -249,7 +249,8 @@

const base::Closure& event_fired_callback,

const base::Closure& event_completed_callback,

ServiceWorkerStatusCode service_worker_status,

- scoped_refptr<ServiceWorkerRegistration> service_worker_registration);

+ const scoped_refptr<ServiceWorkerRegistration>&

+ service_worker_registration);

void FireReadyEventsAllEventsFiring(const base::Closure& callback);

// Called when a sync event has completed.