Remove Context param from LocationUtils methods

Remove Context param from LocationUtils methods

LocationUtils methods require a Context, when the only Context needed
is the Application Context.  This change uses ContextUtils to get the
Application Context and removes the Context parameters from the
relevant methods in LocationUtils.

BUG=631244
Committed: https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28
Cr-Commit-Position: refs/heads/master@{#409093}

[cco3, 2016-07-25 22:25:57]

cco3@chromium.org changed reviewers:
+ jyasskin@chromium.org

[cco3, 2016-07-25 22:26:20]

cco3@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2016-07-26 16:59:41]

lgtm

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:528:
// getInstance() helper method.
I don't think you need to use the {} here because nothing's being overridden. 
Can you clean that up while you're here?

[cco3, 2016-07-26 17:12:01]

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:528:
// getInstance() helper method.
On 2016/07/26 16:59:41, dfalcantara wrote:
> I don't think you need to use the {} here because nothing's being overridden. 
> Can you clean that up while you're here?

Can do.  I also realized that this is going to break some downstream code, so
I'll need to change a couple of things and send this off in parts.

[cco3, 2016-07-26 17:52:46]

cco3@chromium.org changed reviewers:
+ scheib@chromium.org

[cco3, 2016-07-26 17:52:47]

Adding scheib@ for ChromeBluetoothAdapter

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:528:
// getInstance() helper method.
On 2016/07/26 17:12:01, cco3 wrote:
> On 2016/07/26 16:59:41, dfalcantara wrote:
> > I don't think you need to use the {} here because nothing's being
overridden. 
> > Can you clean that up while you're here?
> 
> Can do.  I also realized that this is going to break some downstream code, so
> I'll need to change a couple of things and send this off in parts.

To clarify, do you want me to make the constructor public?

[gone, 2016-07-26 17:55:15]

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:528:
// getInstance() helper method.
On 2016/07/26 17:52:47, cco3 wrote:
> On 2016/07/26 17:12:01, cco3 wrote:
> > On 2016/07/26 16:59:41, dfalcantara wrote:
> > > I don't think you need to use the {} here because nothing's being
> overridden. 
> > > Can you clean that up while you're here?
> > 
> > Can do.  I also realized that this is going to break some downstream code,
so
> > I'll need to change a couple of things and send this off in parts.
> 
> To clarify, do you want me to make the constructor public?

Ah, no.  Just wanted you to remove the braces.  I think we use those only when
we're trying to override some function anonymously.

[gone, 2016-07-26 18:02:28]

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
(right):

https://chromiumcodereview.appspot.com/2183563002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java:528:
// getInstance() helper method.
On 2016/07/26 17:55:15, dfalcantara wrote:
> On 2016/07/26 17:52:47, cco3 wrote:
> > On 2016/07/26 17:12:01, cco3 wrote:
> > > On 2016/07/26 16:59:41, dfalcantara wrote:
> > > > I don't think you need to use the {} here because nothing's being
> > overridden. 
> > > > Can you clean that up while you're here?
> > > 
> > > Can do.  I also realized that this is going to break some downstream code,
> so
> > > I'll need to change a couple of things and send this off in parts.
> > 
> > To clarify, do you want me to make the constructor public?
> 
> Ah, no.  Just wanted you to remove the braces.  I think we use those only when
> we're trying to override some function anonymously.

Well if it doesn't compile without removing the braces, then I've learned
something new today.  Yay Java.  Sorry for leading you astray!

[scheib, 2016-07-26 19:09:28]

device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java
LGTM

[cco3, 2016-07-26 21:27:03]

Hi Jeffrey, your L G T M is needed on LocationUtils.java.

[cco3, 2016-08-01 21:35:25]

cco3@chromium.org changed reviewers:
+ tedchoc@chromium.org

[cco3, 2016-08-01 21:35:25]

Hi Ted, would you be able to review LocationUtils.java?

[Ted C, 2016-08-01 21:42:07]

On 2016/08/01 21:35:25, cco3 wrote:
> Hi Ted, would you be able to review LocationUtils.java?

LocationUtils.java - lgtm

[cco3, 2016-08-01 21:42:57]

On 2016/08/01 21:42:07, Ted C wrote:
> On 2016/08/01 21:35:25, cco3 wrote:
> > Hi Ted, would you be able to review LocationUtils.java?
> 
> LocationUtils.java - lgtm

Thanks

[cco3, 2016-08-01 21:42:57]

On 2016/08/01 21:42:07, Ted C wrote:
> On 2016/08/01 21:35:25, cco3 wrote:
> > Hi Ted, would you be able to review LocationUtils.java?
> 
> LocationUtils.java - lgtm

Thanks

[cco3, 2016-08-01 21:48:14]

The CQ bit was checked by cco3@chromium.org

[cco3, 2016-08-01 21:48:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org, scheib@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2183563002/#ps20001
(title: "Retain one method with context param signature")

[commit-bot: I haz the power, 2016-08-01 21:48:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 22:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:13:22]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[cco3, 2016-08-01 22:35:15]

The CQ bit was checked by cco3@chromium.org

[cco3, 2016-08-01 22:35:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, dfalcantara@chromium.org, scheib@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2183563002/#ps40001
(title: "Update BT Device Fakes class")

[commit-bot: I haz the power, 2016-08-01 22:35:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 23:58:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-02 00:02:37]

Description was changed from

==========
Remove Context param from LocationUtils methods

LocationUtils methods require a Context, when the only Context needed
is the Application Context.  This change uses ContextUtils to get the
Application Context and removes the Context parameters from the
relevant methods in LocationUtils.

BUG=631244
==========

to

==========
Remove Context param from LocationUtils methods

LocationUtils methods require a Context, when the only Context needed
is the Application Context.  This change uses ContextUtils to get the
Application Context and removes the Context parameters from the
relevant methods in LocationUtils.

BUG=631244

Committed: https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28
Cr-Commit-Position: refs/heads/master@{#409093}
==========

[commit-bot: I haz the power, 2016-08-02 00:02:38]

Patchset 3 (id:??) landed as
https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28
Cr-Commit-Position: refs/heads/master@{#409093}